atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david_rad...@uk.ibm.com>
Subject Re: Review Request 55655: IX: Functional Export
Date Wed, 18 Jan 2017 15:05:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55655/#review162109
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/ix/AtlasExportParams.java (line 36)
<https://reviews.apache.org/r/55655/#comment233373>

    can we not define the shape of an import including its parameters in metadata in an atlas
type?



intg/src/main/java/org/apache/atlas/model/ix/AtlasImportParams.java (line 30)
<https://reviews.apache.org/r/55655/#comment233372>

    I am unsure why we need this empty class



webapp/src/main/java/org/apache/atlas/web/rest/ImportExportService.java (line 77)
<https://reviews.apache.org/r/55655/#comment233375>

    I wonder how V1 and V2 entities are exported? Have you tested this?



webapp/src/main/java/org/apache/atlas/web/rest/ImportExportService.java (line 102)
<https://reviews.apache.org/r/55655/#comment233374>

    For imports there are more considerations that exports, I did not see any code around,
managing conflicts, does it update? What happens if the import fails - what do you resubmit.

    
    I would expect a summary of number of records added / updated for an import.
    
    I would have wanted 2 passes of processing for an import. One to validate the import is
sane (does not reference non-existent types / entities, entities are of the shape of the referenced
types),  the next to do the adds/updatse. This reduces the chances of partial imports.


- David Radley


On Jan. 18, 2017, 12:58 a.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55655/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 12:58 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Includes:
> - Export: 
>     - Specify multiple IX items
> - Supported formats:
>     - Json
>     - Json file
>     - Zip file.
> - Using Atlas classes.
> - Updated AtlasExportResult
> 
> Pending:
> - Lineage data.
> - Audit data.
> 
> 
> Diffs
> -----
> 
>   .gitignore cf2ef74 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
9f33115 
>   intg/src/main/java/org/apache/atlas/model/ix/AtlasExportData.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/ix/AtlasExportParams.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/ix/AtlasExportResult.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/ix/AtlasIXItem.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/ix/AtlasImportParams.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/ix/AtlasImportResult.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/service/ImportExportTest.java PRE-CREATION

>   server-api/src/main/java/org/apache/atlas/services/IImportExportService.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/rest/ImportExportREST.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/ImportExportService.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/55655/diff/
> 
> 
> Testing
> -------
> 
> - Verified with hive_db creation.
> - Verified with database created from QuickStart script.
> - File format creation.
> 
> Pending:
> - Import testing.
> 
> 
> File Attachments
> ----------------
> 
> Sample JSON Output
>   https://reviews.apache.org/media/uploaded/files/2017/01/18/c741aea9-7129-4f8f-a9b7-a3c276d03b89__AtlasExportResult.json
> Sample POST Input
>   https://reviews.apache.org/media/uploaded/files/2017/01/18/573a278b-0634-4545-a0e9-e3480fed5e0a__sample-input.sh
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message