atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 55353: Fix for ATLAS-1434.
Date Wed, 11 Jan 2017 23:47:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55353/#review161328
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java (line 92)
<https://reviews.apache.org/r/55353/#comment232568>

    Update/Create can be determined from the isUpdate boolean in createOrUpdateTypes signature.
Is this enum needed ?


- Apoorv Naik


On Jan. 9, 2017, 7:46 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55353/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2017, 7:46 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1434
>     https://issues.apache.org/jira/browse/ATLAS-1434
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Fix for ATLAS-1434. Updated validation for Trait type. Updated error messages to indicate
the operation in which the validation failure was encountered.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 19553bf 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java edd12ab

>   repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 4b500ff

> 
> Diff: https://reviews.apache.org/r/55353/diff/
> 
> 
> Testing
> -------
> 
> - Executed unit tests.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message