atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 54420: ATLAS-1352 : JS error while redirecting to Knox gateway.
Date Wed, 11 Jan 2017 08:32:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54420/#review161187
-----------------------------------------------------------




dashboardv2/public/js/utils/Utils.js (line 84)
<https://reviews.apache.org/r/54420/#comment232425>

    how is error in JSON.parse() being handled?



dashboardv2/public/js/utils/Utils.js (line 85)
<https://reviews.apache.org/r/54420/#comment232424>

    Shouldn't this be:
        redirectURL!=undefined && redirectURL!=''
    
    || ==> &&
    
    Please review.


- Madhan Neethiraj


On Dec. 6, 2016, 1:28 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54420/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 1:28 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Suma Shivaprasad, and Vimal
Sharma.
> 
> 
> Bugs: ATLAS-1352
>     https://issues.apache.org/jira/browse/ATLAS-1352
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch provides fix for JS error while redirecting to Knox Url.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/utils/Utils.js 48963ad 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
75a884d 
> 
> Diff: https://reviews.apache.org/r/54420/diff/
> 
> 
> Testing
> -------
> 
> Tested Atlas login after knox login enabled and disabled.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message