atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation
Date Fri, 06 Jan 2017 02:28:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review160665
-----------------------------------------------------------




client/src/main/java/org/apache/atlas/AtlasClient.java 
<https://reviews.apache.org/r/54287/#comment231848>

    Only white-space changes in this file. Can you please revert?



intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java (line 24)
<https://reviews.apache.org/r/54287/#comment231856>

    "org.apache.atlas.model" package does not seem a good place to for service interfaces.
Please move the service definition to server side.



intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 136)
<https://reviews.apache.org/r/54287/#comment231849>

    no implementation for these 3 methods? Please review.



intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 174)
<https://reviews.apache.org/r/54287/#comment231851>

    Consider changing this to "if (names == null)".



intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 178)
<https://reviews.apache.org/r/54287/#comment231853>

    It may not be useful to prevent duplicate names in the list.. as entries values will have
to be in sync. Consider removing this check and simply add the given name. In fact, it will
be better for this class to not support addName() method.



intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 190)
<https://reviews.apache.org/r/54287/#comment231854>

    Use of 'currentValues' may not be required. Please review and consider directly using
"this.values".


- Madhan Neethiraj


On Jan. 6, 2017, 1:28 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2017, 1:28 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1308
>     https://issues.apache.org/jira/browse/ATLAS-1308
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 154644d 
>   client/src/main/java/org/apache/atlas/AtlasDiscoveryClientV2.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f026ec6 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION

>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 9b56c92 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54287/diff/
> 
> 
> Testing
> -------
> 
> UTs done, tested using POSTMAN rest client.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message