atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 55216: Validation added for names of class, enum, struct and traits.
Date Thu, 05 Jan 2017 20:32:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55216/
-----------------------------------------------------------

(Updated Jan. 5, 2017, 8:32 p.m.)


Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-1408
    https://issues.apache.org/jira/browse/ATLAS-1408


Repository: atlas


Description
-------

Name validation is invoked during type creation.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 4060b85 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java b0a4e07 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
936dd4f 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
c7f6cdf 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
97542d5 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
ee36182 
  repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java a58bd75 
  repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java a0ca7b7


Diff: https://reviews.apache.org/r/55216/diff/


Testing
-------

- Unit tests added to test validation in DefaultMetadataServiceTest.
- Manual tests done by creating types using v2 REST APIs


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message