atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Kantor <dkan...@us.ibm.com>
Subject Re: Review Request 54759: ATLAS-1379 Avoid object query overhead when report query selects class type alias
Date Thu, 05 Jan 2017 14:19:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54759/#review160585
-----------------------------------------------------------


Ship it!




Hi Neeru, I've committed these changes and resolved ATLAS-1379.  Please close this review
 request as submitted.  Thanks...

- David Kantor


On Jan. 3, 2017, 8:21 p.m., Neeru Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54759/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 8:21 p.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Bugs: ATLAS-1379
>     https://issues.apache.org/jira/browse/ATLAS-1379
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> OMS-743 when an object instance is selected in select query then only fetch the id (guid,
typename, version and state) for performance reasons
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fb027efc1ad9a7b2c562fc6670a8f9647b3b54f0

>   repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
aad056f5247cd5ac0e5c84d2f1fa9c4bb5458fb3 
>   repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java
f2a1fe975bc720e3003389806f1e32d3edf74713 
>   repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java a2a9ab6dafcefaa29110051c35d3b6762017a28f

>   repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 51e9ab1fb6bfe7e854bcf40bfc3d92136de4c60f

>   repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java 2c12bc3e82109819759c3c54ba3a786fee656594

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
f6b3fc5ffb6dd76271ccf8217b587b52b98cf78b 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7eacc5dbf186885a3e51294b8717bc9c05bd0b66

>   repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
19ca328a7f4240ea62fdd171f23c6c5c14d25af5 
>   repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala eb6d119b2eca699d67fe071fe2659de2fddb9285

>   repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 9e336cf2abb90141a16220cae078952cdc410475

>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
aaa8fa0d594e97fabfa51c5c76c5aab879bf8e7f 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java d73a7b32add5d9e4eb24afefed042cf894964992

> 
> Diff: https://reviews.apache.org/r/54759/diff/
> 
> 
> Testing
> -------
> 
> All Unit tests executed successfully.
> 
> Added new test cases in GraphBackedDiscoveryTest to valiadte the fields coming back with
id type report queries.
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message