atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation
Date Thu, 05 Jan 2017 08:37:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review160566
-----------------------------------------------------------


Fix it, then Ship it!





client/src/main/java/org/apache/atlas/AtlasClient.java (line 223)
<https://reviews.apache.org/r/54287/#comment231706>

    Consider adding V2 REST methods in a separate client class - similar to AtlasEntitiesClientV2,
AtlasTypedefClientV2. These methods should return structed data, instead of JSONObject.



intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 53)
<https://reviews.apache.org/r/54287/#comment231707>

    Would a search-result have values for fields entities/attributes/fullTextResult? If these
are mutually exclusive, consider using 3 different constructors - it will be handly to construct
with only available attributes.



intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 74)
<https://reviews.apache.org/r/54287/#comment231708>

    This method ends up creating a duplicate list, with size of the exising list. Consider
alternate of modifying the exising list, by removing existing entry for newEntity and append.



intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 168)
<https://reviews.apache.org/r/54287/#comment231709>

    Why duplicate the list and then append? Consider directly adding to the exising list.


- Madhan Neethiraj


On Jan. 4, 2017, 11:10 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 11:10 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1308
>     https://issues.apache.org/jira/browse/ATLAS-1308
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 154644d 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 94a249c 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION

>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54287/diff/
> 
> 
> Testing
> -------
> 
> UTs done, tested using POSTMAN rest client.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message