atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 55138: ATLAS-1424 - Avoid stack-trace in REST API error response
Date Tue, 03 Jan 2017 16:56:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55138/#review160394
-----------------------------------------------------------


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/util/Servlets.java (line 140)
<https://reviews.apache.org/r/55138/#comment231525>

    printStackTrace() method is no more referenced; hence can be removed. I will remove it
before committing the patch.


- Madhan Neethiraj


On Jan. 3, 2017, 2:23 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55138/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2017, 2:23 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1424
>     https://issues.apache.org/jira/browse/ATLAS-1424
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch provides fix to avoid stack-trace in REST API error response, by removing
stacktrace attribute from json response.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/util/Servlets.java b4f0839 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 23203ec

> 
> Diff: https://reviews.apache.org/r/55138/diff/
> 
> 
> Testing
> -------
> 
> Execute test cases using mvn clean install
> 
> Tested json response for discovery, types, entity type of api's in normal & exceptional
conditions.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message