Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3CE0D200BE3 for ; Thu, 22 Dec 2016 18:48:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3B56F160B26; Thu, 22 Dec 2016 17:48:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 61A49160B1B for ; Thu, 22 Dec 2016 18:48:52 +0100 (CET) Received: (qmail 32015 invoked by uid 500); 22 Dec 2016 17:48:51 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 32000 invoked by uid 99); 22 Dec 2016 17:48:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2016 17:48:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C1EA7C0974 for ; Thu, 22 Dec 2016 17:48:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.018 X-Spam-Level: X-Spam-Status: No, score=-5.018 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 5XqCZXY48Ezh for ; Thu, 22 Dec 2016 17:48:45 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A1C495F1B3 for ; Thu, 22 Dec 2016 17:48:44 +0000 (UTC) Received: (qmail 31808 invoked by uid 99); 22 Dec 2016 17:48:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2016 17:48:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 306E630F5F0; Thu, 22 Dec 2016 17:48:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5703235881229612106==" MIME-Version: 1.0 Subject: Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs From: David Radley To: Sarath Subramanian , Madhan Neethiraj , Shwetha GS Cc: David Radley , Apoorv Naik , atlas Date: Thu, 22 Dec 2016 17:48:43 -0000 Message-ID: <20161222174843.1708.43128@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David Radley X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54058/ X-Sender: David Radley References: <20161221022547.1708.73221@reviews.apache.org> In-Reply-To: <20161221022547.1708.73221@reviews.apache.org> X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java Reply-To: David Radley X-ReviewRequest-Repository: atlas archived-at: Thu, 22 Dec 2016 17:48:53 -0000 --===============5703235881229612106== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review159980 ----------------------------------------------------------- I am looking for tests that drive the Entity V2 API with updates to LIST and SET attributes for foreign keys and map from refs. It would be good to show how to update a LIST - for eaxmple can you add a member into the middle of the list. Is this be in scope for this Jira? - David Radley On Dec. 21, 2016, 2:25 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54058/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 2:25 a.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. > > > Bugs: ATLAS-1311 > https://issues.apache.org/jira/browse/ATLAS-1311 > > > Repository: atlas > > > Description > ------- > > ATLAS-1311: Integration tests for the V2 Entity APIs > > > Diffs > ----- > > .gitignore d2fbdc01 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java e5bd65a8 > client/src/main/java/org/apache/atlas/AtlasBaseClient.java a95bf32d > client/src/main/java/org/apache/atlas/AtlasClient.java 47231a87 > client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 16556c8c > client/src/main/java/org/apache/atlas/AtlasServiceException.java 4719e7cf > client/src/main/java/org/apache/atlas/AtlasTypedefClientV2.java a1935247 > intg/src/main/java/org/apache/atlas/model/SearchFilter.java 4d8b258e > intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 35f2f144 > repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java 1a3c31c9 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java 6b2b2166 > webapp/src/main/java/org/apache/atlas/util/RestUtils.java 7597dcbe > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java 5756adb5 > webapp/src/main/java/org/apache/atlas/web/resources/BaseService.java dfd29b14 > webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 > webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java ac4f9f1a > webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java cc98207c > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 768ef12c > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 2529f0dd > webapp/src/main/resources/spring-security.xml 4ba30255 > webapp/src/main/webapp/WEB-INF/applicationContext.xml 6129605d > webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java 01e4d483 > webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java de0a459b > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java e37839a2 > webapp/src/test/java/org/apache/atlas/web/resources/AdminJerseyResourceIT.java 2a4babae > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 325c25b4 > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java 7e4db13f > webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027 > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java c681a0f9 > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java PRE-CREATION > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java ed37c3a1 > webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 87bf9a89 > > Diff: https://reviews.apache.org/r/54058/diff/ > > > Testing > ------- > > UTs and ITs are running fine. mvn clean install -Pdist was successful > > > Thanks, > > Apoorv Naik > > --===============5703235881229612106==--