Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 17EF6200BCE for ; Fri, 2 Dec 2016 23:57:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 168C9160B24; Fri, 2 Dec 2016 22:57:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5EE65160B08 for ; Fri, 2 Dec 2016 23:57:10 +0100 (CET) Received: (qmail 35478 invoked by uid 500); 2 Dec 2016 22:57:09 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 35454 invoked by uid 99); 2 Dec 2016 22:57:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 22:57:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CD4FB1AABC0 for ; Fri, 2 Dec 2016 22:57:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 0Am_AgQa41xw for ; Fri, 2 Dec 2016 22:57:07 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 8E3685FBAD for ; Fri, 2 Dec 2016 22:57:06 +0000 (UTC) Received: (qmail 33489 invoked by uid 99); 2 Dec 2016 22:56:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Dec 2016 22:56:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 5A85B2D9221; Fri, 2 Dec 2016 22:56:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8872145350249444479==" MIME-Version: 1.0 Subject: Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation From: Sarath Subramanian To: Apoorv Naik , Madhan Neethiraj Cc: Vimal Sharma , Sarath Subramanian , atlas Date: Fri, 02 Dec 2016 22:56:30 -0000 Message-ID: <20161202225630.1642.9683@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54287/ X-Sender: Sarath Subramanian References: <20161202224755.1642.95690@reviews.apache.org> In-Reply-To: <20161202224755.1642.95690@reviews.apache.org> X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Fri, 02 Dec 2016 22:57:11 -0000 --===============8872145350249444479== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54287/ ----------------------------------------------------------- (Updated Dec. 2, 2016, 2:56 p.m.) Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad. Bugs: ATLAS-1308 https://issues.apache.org/jira/browse/ATLAS-1308 Repository: atlas Description ------- Model and implement the new Discovery REST API's for the following search types: * DSL Search * Full Text Search and retrieve search results in a structured model using AtlasEntityHeader information. Diffs (updated) ----- intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 84d8173 intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fb repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION repository/src/main/scala/org/apache/atlas/query/Expressions.scala 297aa2b webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java PRE-CREATION Diff: https://reviews.apache.org/r/54287/diff/ Testing ------- UTs in progress, tested using POSTMAN rest client. Thanks, Sarath Subramanian --===============8872145350249444479==--