atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sarath.ku...@gmail.com>
Subject Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation
Date Wed, 28 Dec 2016 23:39:06 GMT


> On Dec. 2, 2016, 2:09 a.m., Vimal Sharma wrote:
> > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java, line
77
> > <https://reviews.apache.org/r/54287/diff/1/?file=1574544#file1574544line77>
> >
> >     Can we use a HashMap here so that while adding an element, we don't have to
iterate over the entire list to determine its membership.

could not use hashmap since in search results we want a list of entities and not a map.


> On Dec. 2, 2016, 2:09 a.m., Vimal Sharma wrote:
> > intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java, line
148
> > <https://reviews.apache.org/r/54287/diff/1/?file=1574544#file1574544line148>
> >
> >     Please consider using HashMap.

refactored the block


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review157719
-----------------------------------------------------------


On Dec. 28, 2016, 3:37 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2016, 3:37 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1308
>     https://issues.apache.org/jira/browse/ATLAS-1308
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasClient.java 154644d 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 94a249c 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 538534f 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java 8e086c9 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION

>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 81be7db 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54287/diff/
> 
> 
> Testing
> -------
> 
> UTs done, tested using POSTMAN rest client.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message