atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 54906: ATLAS-1407: Improve LOG statement performance
Date Tue, 20 Dec 2016 22:30:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54906/
-----------------------------------------------------------

(Updated Dec. 20, 2016, 10:30 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and Vimal
Sharma.


Changes
-------

Addressed couple of issues.


Bugs: ATLAS-1407
    https://issues.apache.org/jira/browse/ATLAS-1407


Repository: atlas


Description
-------

ATLAS-1407: Improve LOG statement performance

Link to SLF4J docs -> http://slf4j.org/faq.html#logging_performance


Diffs (updated)
-----

  addons/falcon-bridge-shim/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
6b4486a2 
  addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java b6312d73

  addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 2acc5755

  addons/hive-bridge-shim/src/main/java/org/apache/atlas/hive/hook/HiveHook.java f4ca94fd

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java 0f8afd55

  addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 4b736a87 
  addons/sqoop-bridge-shim/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 1170cb64

  addons/storm-bridge-shim/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java 2d304c5c

  authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizerFactory.java 5aad72d6

  authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
2ef4ea28 
  authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 5740a1cf

  authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 8a3850fa 
  authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java
5956f5c9 
  catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java a301912e 
  common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java ed42aa65 
  common/src/main/java/org/apache/atlas/utils/AtlasPerfTracer.java 05ec7f16 
  intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java ee78350c 
  notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 5bdd5d34 
  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 0ebfd478 
  plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoader.java
0dbf3528 
  plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java
69b61d61 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java a7124bf8 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
f0647a47 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 6eeddaea 
  repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
78e276e5 
  repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
b3531b06 
  repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java c2f8b3f9

  server-api/src/main/java/org/apache/atlas/aspect/AtlasAspect.java 28017500 
  server-api/src/main/java/org/apache/atlas/ha/AtlasServerIdSelector.java f3d36a71 
  webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java a4fd1c2f

  webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 8f6613af 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java b7528104

  webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 26e6b1e2

  webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
75a884dc 
  webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 3bab6500 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28 
  webapp/src/main/java/org/apache/atlas/web/setup/AtlasSetup.java 259285e3 
  webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java bc532e91 
  webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f 
  webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027

  webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 44b7cac5


Diff: https://reviews.apache.org/r/54906/diff/


Testing
-------

Not needed as it's only logging change.

Verified (few obvious ones) that the exceptions are getting printed in the logs, existing
TypesResource does the same thing and the exceptions are getting printed after parameterization
of the message.

Will try to capture a before and after server log for a clean install run.


Thanks,

Apoorv Naik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message