atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 54906: ATLAS-1407: Improve LOG statement performance
Date Tue, 20 Dec 2016 21:33:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54906/#review159749
-----------------------------------------------------------




addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java (line 145)
<https://reviews.apache.org/r/54906/#comment230786>

    Can you confirm if this prints the exception details - like the earlier usage? It it treats
"t" as another variable-length argument, exception details might be lost in the log.



intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java (line 312)
<https://reviews.apache.org/r/54906/#comment230787>

    Can you confirm that "excp" is printed in the log, as in earlier usage? It shouldn't be
treated as another variable-length argument (and ignored, as there are no references in the
format-string).



intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java (line 332)
<https://reviews.apache.org/r/54906/#comment230788>

    Can you confirm that "excp" is printed in the log, as in earlier usage? It shouldn't be
treated as another variable-length argument (and ignored, as there are no references in the
format-string).



intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java (line 353)
<https://reviews.apache.org/r/54906/#comment230789>

    Can you confirm that "excp" is printed in the log, as in earlier usage? It shouldn't be
treated as another variable-length argument (and ignored, as there are no references in the
format-string).



notification/src/main/java/org/apache/atlas/hook/AtlasHook.java (line 193)
<https://reviews.apache.org/r/54906/#comment230790>

    there are two "{}" - but with only one argument. please review.



notification/src/main/java/org/apache/atlas/hook/AtlasHook.java (line 200)
<https://reviews.apache.org/r/54906/#comment230791>

    there are two "{}" but with only one argument. please review.



plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoader.java
(line 285)
<https://reviews.apache.org/r/54906/#comment230792>

    Can you confirm that "t" is printed in the log, as in earlier usage? It shouldn't be treated
as another variable-length argument (and ignored, as there are no references in the format-string).



plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java
(line 81)
<https://reviews.apache.org/r/54906/#comment230793>

    Can you confirm that "excp" is printed in the log, as in earlier usage? It shouldn't be
treated as another variable-length argument (and ignored, as there are no references in the
format-string).



plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java
(line 87)
<https://reviews.apache.org/r/54906/#comment230794>

    Can you confirm that "excp" is printed in the log, as in earlier usage? It shouldn't be
treated as another variable-length argument (and ignored, as there are no references in the
format-string).



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
(line 133)
<https://reviews.apache.org/r/54906/#comment230795>

    Can you confirm that "t" is printed in the log, as in earlier usage? It shouldn't be treated
as another variable-length argument (and ignored, as there are no references in the format-string).



webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java (line 416)
<https://reviews.apache.org/r/54906/#comment230800>

    Can you confirm that "ex" is printed in the log, as in earlier usage? It shouldn't be
treated as another variable-length argument (and ignored, as there are no references in the
format-string).



webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java (line 281)
<https://reviews.apache.org/r/54906/#comment230799>

    Can you confirm that "e" is printed in the log, as in earlier usage? It shouldn't be treated
as another variable-length argument (and ignored, as there are no references in the format-string).



webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java (line 284)
<https://reviews.apache.org/r/54906/#comment230798>

    Can you confirm that "e" is printed in the log, as in earlier usage? It shouldn't be treated
as another variable-length argument (and ignored, as there are no references in the format-string).


- Madhan Neethiraj


On Dec. 20, 2016, 6:13 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54906/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2016, 6:13 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma Shivaprasad, and
Vimal Sharma.
> 
> 
> Bugs: ATLAS-1407
>     https://issues.apache.org/jira/browse/ATLAS-1407
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1407: Improve LOG statement performance
> 
> Link to SLF4J docs -> http://slf4j.org/faq.html#logging_performance
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge-shim/src/main/java/org/apache/atlas/falcon/service/AtlasService.java
6b4486a23ea945d24ef02143cd26d3aa47b11cb3 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/hook/FalconHook.java b6312d73aa116a61e2898f60c511e4fe73ab9505

>   addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 2acc5755ba62c5368d19525709a4abbbff52c4b0

>   addons/hive-bridge-shim/src/main/java/org/apache/atlas/hive/hook/HiveHook.java f4ca94fd8e7af9e6a787266020f2b90d3c60462b

>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
0f8afd55138f9af0ec66ba30967157fa0b1a7140 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 4b736a875135fc8b59d3fe86fcbf394207cf4bc7

>   addons/sqoop-bridge-shim/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 1170cb64c9fef0b72ccc024c5662ed50a5d26457

>   addons/storm-bridge-shim/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
2d304c5cdc5be4a848b226632a117ab0b58b746e 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizerFactory.java
5aad72d6e1989a0ab49a8d5d4bd273aa37b51adf 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
2ef4ea28c8d6786b6fe30067f27e9e5174104721 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 5740a1cf500b5a8a90f2e9d4371bb10b18e01a38

>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 8a3850fae0d2c737e3a15991402eed48c177c667

>   authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java
5956f5c9a4c580a96245b71c8182b5ddb486bc49 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryFactory.java a301912e2e1a0fbf3f5c5bfacc03d65f2390bbd7

>   common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java ed42aa65e7b99058d44f50f02235d72c6b89b12d

>   common/src/main/java/org/apache/atlas/utils/AtlasPerfTracer.java 05ec7f16276aa65559be483cf1523e83a14856b6

>   intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java ee78350cd8501bd54d08851b0350fc55471e87b7

>   notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 5bdd5d3446fd409c0c13474433f2890efee2b851

>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 0ebfd47897ff2fce28320be0153125ac8c7b4dde

>   plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoader.java
0dbf3528788bd3f63d97eb6286c52f661f6d2cd1 
>   plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java
69b61d61aca8093cd25dda2821e13fcbbc9ac4bc 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java a7124bf8690f5f6a33e1d7a04aaaec976167ec6f

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
f0647a47221cf8bd13d8b68f12f25f4e721249f0 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 6eeddaea9d1868f01090dbe37a23ccda5fccf0f9

>   repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
78e276e5972f6bba68198b3ae5a3d88676cf7585 
>   repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
b3531b06967b99743a3c6a54b5fe85dff208b8eb 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java c2f8b3f9785db0d0302ddf181e1e12427562e6ca

>   server-api/src/main/java/org/apache/atlas/aspect/AtlasAspect.java 28017500db3ddaf2d9636d11d3b6c8597dd52394

>   server-api/src/main/java/org/apache/atlas/ha/AtlasServerIdSelector.java f3d36a7140725ef2452d8a4a3b34e9edfe065858

>   webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java a4fd1c2fc77e05f69e26f8ac5bb4b1feabab3606

>   webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java 8f6613af7a357ea90f34534309c8c5d67f2b6582

>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java b7528104c54c01fc125078e81592b2359241d02f

>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 26e6b1e2ffc2512ed7039b2e0d309dfdb45a1353

>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
75a884dca7f0698a00aaed027b5b9ad21cae6aa3 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 3bab65005f6c02410ccecf07e611784c3aec67bf

>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 8a663c28dba0fbb9ab1549ef9c1fa6dd0ebc0c69

>   webapp/src/main/java/org/apache/atlas/web/setup/AtlasSetup.java 259285e3e3efd086fdc1b67ac486589beb30b8c1

>   webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java bc532e91ea3e0b816e800e6841cabd43e3f6e732

>   webapp/src/test/java/org/apache/atlas/notification/EntityNotificationIT.java ec62112f5cfc8bf0e822e4e399bb41c573ee05e8

>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java 22bcc027e75f986b2f341e371ceee8cd3a3afa64

>   webapp/src/test/java/org/apache/atlas/web/security/FileAuthenticationTest.java 44b7cac5bf72625e2603595c3e35eac4f66556ff

> 
> Diff: https://reviews.apache.org/r/54906/diff/
> 
> 
> Testing
> -------
> 
> Not needed as it's only logging change.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message