atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification
Date Thu, 15 Dec 2016 21:44:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/#review159373
-----------------------------------------------------------




typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java (line 100)
<https://reviews.apache.org/r/53789/#comment230356>

    This change shouldn't be here. It's a wrong negation expression.


- Apoorv Naik


On Dec. 14, 2016, 8:40 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53789/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 8:40 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, Suma Shivaprasad,
and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1304
>     https://issues.apache.org/jira/browse/ATLAS-1304
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Redundant code removal and code simplification
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java 0b918ba0

>   addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java 8d0a47a6

>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
cbc51cc4 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java cf8851c0

>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java
79a1afe7 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 5abf2dfe 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
0cba27ea 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 23a13ea3

>   addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java
edd95ba4 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java b42162fd

>   authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 9c50a040

>   authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java e34c7403

>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
e48c5ae7 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java 68362491

>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 2a6929a6

>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 9508eb3e

>   authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java
57156b78 
>   authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java
453364d7 
>   authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java 3453bf0e

>   authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java
8b27e2ea 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java ee9fbba6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java f111eb61 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java d60e3f3c 
>   catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java
47d182cc 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 78436c0c

>   catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java 510378e4

>   client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b 
>   client/src/main/java/org/apache/atlas/security/SecureClientUtils.java e13d826e 
>   client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891 
>   common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java b60edef9 
>   common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java fb32ff55

>   common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java bf1175f4 
>   common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43 
>   dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
5d60c678 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
f2e0f9d6 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
39c309d6 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
c205b975 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/InPredicate.java
46831a5e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/OrCondition.java
80033b40 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompat.java
c9b03aad 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseCompatLoader.java
2c0d6fe5 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseKeyColumnValueStore.java
c5f6e0d8 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/hbase/HBaseStoreManager.java
a94a7e47 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediator.java
20c59e1a 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/diskstorage/solr/Solr5Index.java
f3b9fd90 
>   graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java
89c02c8d 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java
7c8cfe8c 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphIndex.java
7beed78d 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Vertex.java
9ca04415 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
9f9c8ae7 
>   graphdb/titan0/src/test/java/com/thinkaurelius/titan/diskstorage/locking/LocalLockMediatorTest.java
d0fd401a 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/GraphQueryTest.java
bf4519c7 
>   graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java
e82de487 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4e4a9e8b 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 0c4de4d2

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
146d3c97 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 41385f52 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 45efb04d

>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java 6119dafc 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java e2d61818 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 70321822

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 480b27b8 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java 69d7b301 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 4de71799 
>   intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 48d0a27e 
>   intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c135073c 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 83b6385e 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 96f3da4e 
>   intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java eba87a76 
>   intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 60899fdc 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ef5f7364 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 0c118f07 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6eed60f9 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104 
>   intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java c0bb1f2d 
>   intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java b8cc77c5

>   intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java 61e102ec 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e1a96587 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java 0d8c65f8 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java f234bb81 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java 4373a38d 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasByteType.java 338cedaf 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java fc2de257

>   intg/src/test/java/org/apache/atlas/type/TestAtlasDateType.java a28840a1 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java 1b1e0138 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 90fea9f3 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java dbfcf1d5 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasIntType.java f6f60415 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasLongType.java b9fb0890 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasMapType.java 6f75d549 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java 61f9146c 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasShortType.java a266305e 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasStringType.java c171d986 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java ee05ba36 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 2309edec 
>   plugin-classloader/src/main/java/org/apache/atlas/plugin/classloader/AtlasPluginClassLoaderUtil.java
c3ec5e27 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fbf 
>   repository/src/main/java/org/apache/atlas/discovery/DataSetLineageService.java fcf120ab

>   repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java
c0cc25ca 
>   repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java 6b689615

>   repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java ca1ad5df

>   repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java
f2bfc6d6 
>   repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java ae1ec45a

>   repository/src/main/java/org/apache/atlas/repository/graph/EntityProcessor.java 59472e4c

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
1a3faf77 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
9ef31601 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cb54c3e6

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphSchemaInitializer.java
51d59287 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
84608d9d 
>   repository/src/main/java/org/apache/atlas/repository/memory/AttributeStores.java a0cbb62f

>   repository/src/main/java/org/apache/atlas/repository/memory/ClassStore.java 7fcfffeb

>   repository/src/main/java/org/apache/atlas/repository/memory/HierarchicalTypeStore.java
d7acf977 
>   repository/src/main/java/org/apache/atlas/repository/memory/MemRepository.java 75b49794

>   repository/src/main/java/org/apache/atlas/repository/memory/ReplaceIdWithInstance.java
9351be94 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
1ad04b33 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
19c87011 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
bef6d18e 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
ab3b3d91 
>   repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
ee630616 
>   repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d

>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java d2793d2c

>   repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a270b978

>   repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java 0ed370c3 
>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
fba6d195 
>   repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
7ae5e203 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperMockTest.java
dbd4bf12 
>   repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java
000f2f41 
>   repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d659c0ff

>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java
75ec9a24 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/StructInstance.java
6fb2087a 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 63988293

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 425e163e

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalType.java 392d2bf9

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphTraversal.java
a8f2eeb5 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/ObjectGraphWalker.java 81884e8f

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/StructType.java 5d257307

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9e

>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypedStructHandler.java
b97669a3 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/cache/TypeCache.java 87d83a6a

>   typesystem/src/main/scala/org/apache/atlas/typesystem/builders/InstanceBuilder.scala
df1851ca 
>   typesystem/src/main/scala/org/apache/atlas/typesystem/builders/TypesBuilder.scala f18151aa

>   typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
6f63d0f3 
>   typesystem/src/test/java/org/apache/atlas/typesystem/json/SerializationJavaTest.java
eb1a15a3 
>   typesystem/src/test/java/org/apache/atlas/typesystem/types/StructTest.java e52962bd

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/TraitTest.java 31bfb2cf

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/TypeSystemTest.java 96946eae

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/ValidationTest.java 0748f8f3

>   typesystem/src/test/java/org/apache/atlas/typesystem/types/cache/DefaultTypeCacheTest.java
f885a6b8 
>   webapp/src/main/java/org/apache/atlas/web/dao/UserDao.java e746855e 
>   webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 1ff80003

>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 33070156

>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java 5bd2bd73

>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java 3cc83c57

>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java ec5d891f 
>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java 62e1e578 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
b99a30ae 
>   webapp/src/main/java/org/apache/atlas/web/service/CuratorFactory.java c57de844 
>   webapp/src/main/java/org/apache/atlas/web/service/UserService.java 33101e2c 
>   webapp/src/main/java/org/apache/atlas/web/setup/SetupSteps.java b060def0 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartIT.java c2f89bd2 
>   webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
961154b8 
>   webapp/src/test/java/org/apache/atlas/web/filters/ActiveServerFilterTest.java b3ec8de4

>   webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java
f85892ac 
>   webapp/src/test/java/org/apache/atlas/web/listeners/LoginProcessorIT.java 42692cd9

>   webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java 88cfc638

>   webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java b5af111f

>   webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java 3f20453f

>   webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java ff2cfc39 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 6823c830

>   webapp/src/test/java/org/apache/atlas/web/service/ActiveInstanceStateTest.java 599e9cbf

>   webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java
455f121f 
> 
> Diff: https://reviews.apache.org/r/53789/diff/
> 
> 
> Testing
> -------
> 
> Unit Tests passing.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message