atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve hierarchical references
Date Tue, 06 Dec 2016 22:03:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158229
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java (line 122)
<https://reviews.apache.org/r/54233/#comment229024>

    didnt get why we need to toUppercase here..cant we directly do on typeCategory instead?


- Suma Shivaprasad


On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2016, 10:33 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1345
>     https://issues.apache.org/jira/browse/ATLAS-1345
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc

>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
816832b912130e89279cd6cd3e8c3e94c85fa6a8 
>   repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7

>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649

> 
> Diff: https://reviews.apache.org/r/54233/diff/
> 
> 
> Testing
> -------
> 
> UTs passing for AtlasTypedefStore
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message