atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 54287: [ATLAS-1308] Discovery/Search REST API v2 model and implementation
Date Fri, 02 Dec 2016 20:44:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54287/#review157763
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java (line 102)
<https://reviews.apache.org/r/54287/#comment228375>

    This one can also be Objects.equals as it internally calls .equals



repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java (line 197)
<https://reviews.apache.org/r/54287/#comment228377>

    Any reason we're not using AtlasGraphQuery to build our queries ?



repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java (line 201)
<https://reviews.apache.org/r/54287/#comment228378>

    Misleading name, if it's named isEntitiesList I'd expect instanceof checks against a *Entity
class


- Apoorv Naik


On Dec. 2, 2016, 3:11 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54287/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 3:11 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1308
>     https://issues.apache.org/jira/browse/ATLAS-1308
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Model and implement the new Discovery REST API's for the following search types:
> * DSL Search
> * Full Text Search
> and retrieve search results in a structured model using AtlasEntityHeader information.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 84d8173 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasDiscoveryService.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fb 
>   repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java PRE-CREATION

>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 297aa2b 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54287/diff/
> 
> 
> Testing
> -------
> 
> UTs in progress, tested using POSTMAN rest client.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message