Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 107C5200BB7 for ; Wed, 9 Nov 2016 07:47:21 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0EEF6160AFD; Wed, 9 Nov 2016 06:47:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 54E28160AEE for ; Wed, 9 Nov 2016 07:47:20 +0100 (CET) Received: (qmail 45261 invoked by uid 500); 9 Nov 2016 06:47:19 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 45247 invoked by uid 99); 9 Nov 2016 06:47:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2016 06:47:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9EB79C0118 for ; Wed, 9 Nov 2016 06:47:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id tYg3-F5CzKeD for ; Wed, 9 Nov 2016 06:47:16 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 035705F54F for ; Wed, 9 Nov 2016 06:47:14 +0000 (UTC) Received: (qmail 44781 invoked by uid 99); 9 Nov 2016 06:46:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2016 06:46:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EB1852DD94E; Wed, 9 Nov 2016 06:46:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6115660852087081941==" MIME-Version: 1.0 Subject: Re: Review Request 53595: Added minimal data structure for typedef calls From: Sarath Subramanian To: Sarath Subramanian , Madhan Neethiraj , Shwetha GS Cc: Apoorv Naik , atlas Date: Wed, 09 Nov 2016 06:46:50 -0000 Message-ID: <20161109064650.4232.43479@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53595/ X-Sender: Sarath Subramanian References: <20161109052726.724.53694@reviews.apache.org> In-Reply-To: <20161109052726.724.53694@reviews.apache.org> X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/TypeCategory.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Wed, 09 Nov 2016 06:47:21 -0000 --===============6115660852087081941== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53595/#review155407 ----------------------------------------------------------- intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java (line 59) will hit NPE - incorrect assignment here, swap the statements in if else block. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java (line 61) can move package name to import to improve readability. Used in multiple places. import org.apache.atlas.model.TypeCategory; webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java (line 399) can make the path simpler - GET /typedefs - Sarath Subramanian On Nov. 8, 2016, 9:27 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53595/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 9:27 p.m.) > > > Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. > > > Bugs: ATLAS-1278 > https://issues.apache.org/jira/browse/ATLAS-1278 > > > Repository: atlas > > > Description > ------- > > Added minimal data structure for typedef calls > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/TypeCategory.java PRE-CREATION > intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java PRE-CREATION > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java e8092a5 > intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java c7dad29 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java d841977 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 7170ee4 > intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java e9a2021 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 0ebfa26 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java c8c2216 > intg/src/main/java/org/apache/atlas/type/AtlasType.java a507bf4 > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 43f93d4 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 5babae5 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 6dfe8cf > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java d0cb209 > > Diff: https://reviews.apache.org/r/53595/diff/ > > > Testing > ------- > > > Thanks, > > Apoorv Naik > > --===============6115660852087081941==--