Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AC0E6200BBD for ; Tue, 8 Nov 2016 22:46:30 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AA9EB160B0A; Tue, 8 Nov 2016 21:46:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F25D6160AD0 for ; Tue, 8 Nov 2016 22:46:29 +0100 (CET) Received: (qmail 98977 invoked by uid 500); 8 Nov 2016 21:46:29 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 98966 invoked by uid 99); 8 Nov 2016 21:46:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Nov 2016 21:46:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7247C181360 for ; Tue, 8 Nov 2016 21:46:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id uWKqH-0HDwmn for ; Tue, 8 Nov 2016 21:46:27 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A81E65F19B for ; Tue, 8 Nov 2016 21:46:26 +0000 (UTC) Received: (qmail 98936 invoked by uid 99); 8 Nov 2016 21:46:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Nov 2016 21:46:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A8AEB2DD8AE; Tue, 8 Nov 2016 21:46:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4848672531433862408==" MIME-Version: 1.0 Subject: Re: Review Request 53073: Lineage REST API v2 implementation From: Sarath Subramanian To: Apoorv Naik , Madhan Neethiraj , Shwetha GS Cc: Sarath Subramanian , atlas Date: Tue, 08 Nov 2016 21:46:24 -0000 Message-ID: <20161108214624.4232.67658@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Sarath Subramanian X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53073/ X-Sender: Sarath Subramanian References: <20161108200533.4231.39494@reviews.apache.org> In-Reply-To: <20161108200533.4231.39494@reviews.apache.org> X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java Reply-To: Sarath Subramanian X-ReviewRequest-Repository: atlas archived-at: Tue, 08 Nov 2016 21:46:30 -0000 --===============4848672531433862408== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53073/ ----------------------------------------------------------- (Updated Nov. 8, 2016, 1:46 p.m.) Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad. Changes ------- updated unit and integration tests. Bugs: ATLAS-1234 https://issues.apache.org/jira/browse/ATLAS-1234 Repository: atlas Description ------- Initial model and implementation for updated lineage rest apis for input, output and full lineage for dataset entity. Diffs (updated) ----- common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317 intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269 repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java PRE-CREATION Diff: https://reviews.apache.org/r/53073/diff/ Testing (updated) ------- unit test and integration test updated. Thanks, Sarath Subramanian --===============4848672531433862408==--