Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F2405200BC4 for ; Sat, 5 Nov 2016 00:24:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F0C4F160B04; Fri, 4 Nov 2016 23:24:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4406E160AFE for ; Sat, 5 Nov 2016 00:24:48 +0100 (CET) Received: (qmail 21345 invoked by uid 500); 4 Nov 2016 23:24:47 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 21333 invoked by uid 99); 4 Nov 2016 23:24:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 23:24:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C7B1B1A944A for ; Fri, 4 Nov 2016 23:24:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id fHpNvN97Cefo for ; Fri, 4 Nov 2016 23:24:44 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 91CF95F3BE for ; Fri, 4 Nov 2016 23:24:43 +0000 (UTC) Received: (qmail 21298 invoked by uid 99); 4 Nov 2016 23:24:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Nov 2016 23:24:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D34BC2DD025; Fri, 4 Nov 2016 23:24:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8760549564929366412==" MIME-Version: 1.0 Subject: Re: Review Request 53316: Initial draft of changes for ATLAS Entities REST to talk to v1 backend From: Suma Shivaprasad To: Apoorv Naik , atlas Date: Fri, 04 Nov 2016 23:24:41 -0000 Message-ID: <20161104232441.1746.69733@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53316/ X-Sender: Suma Shivaprasad References: <20161104223610.31640.2676@reviews.apache.org> In-Reply-To: <20161104223610.31640.2676@reviews.apache.org> X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/adapters/AtlasPrimitiveValueValidator.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/adapters/AtlasInstanceValueValidation.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityToEntityConverterTest.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityvsReferenceValidator.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/instance/AtlasTransientId.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java X-ReviewBoard-Diff-For: webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityValidators.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityToReferenceableConverter.java Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas archived-at: Fri, 04 Nov 2016 23:24:49 -0000 --===============8760549564929366412== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53316/ ----------------------------------------------------------- (Updated Nov. 4, 2016, 11:24 p.m.) Review request for atlas. Bugs: ATLAS-1257 https://issues.apache.org/jira/browse/ATLAS-1257 Repository: atlas Description ------- EntitiesREST will talk to the ATLAS v1 backend by converting from a. AtlasEntity to Referenceable b. AtlasStruct to Struct c. Map of complex types d. Array of complex types and call the V1 backend directly as a workaround before v2 implementation is completely ready. Diffs ----- distro/src/bin/atlas_stop.py a2b1c31 intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 709fcbc intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27 intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea intg/src/main/java/org/apache/atlas/model/instance/AtlasTransientId.java PRE-CREATION intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java a2f7463 intg/src/test/java/org/apache/atlas/TestUtilsV2.java bae9d3b repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java cd44318 repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 95c3dd9 server-api/src/main/java/org/apache/atlas/services/MetadataService.java 2351891 webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityToReferenceableConverter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatAdapter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConvertersModule.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructToStructConverter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java 0c2e0ec webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 543cbe2 webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityToEntityConverterTest.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityValidators.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/adapters/AtlasEntityvsReferenceValidator.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/adapters/AtlasInstanceValueValidation.java PRE-CREATION webapp/src/test/java/org/apache/atlas/web/adapters/AtlasPrimitiveValueValidator.java PRE-CREATION Diff: https://reviews.apache.org/r/53316/diff/ Testing (updated) ------- Pending - UTS in progress REST layer - tested create and update through the new APIs Thanks, Suma Shivaprasad --===============8760549564929366412==--