atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neeru Gupta <guptane...@us.ibm.com>
Subject Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes
Date Tue, 29 Nov 2016 15:38:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 3:38 p.m.)


Review request for atlas and Jeff Hagelberg.


Repository: atlas


Description
-------

Aggregate methods and order by fixes.


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java a901b5127b3dcd2939fec2c642475d7aad869d8e

  repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java 32189bc6dab4cc25748e7b6136dc0a89476012c7

  repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java 9a36e780850d0c349343d6a751c5e7f181c86198

  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 297aa2b8f917d5ae25da6a69901af60542082642

  repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 6803036df7ef7b7c7c08579f1f7cbd4c731aec46

  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df

  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 7074d74770a5098ca82852919f236fd66c6d4a84

  repository/src/main/scala/org/apache/atlas/query/Resolver.scala cff92afe98a6215499a70a9ef00a937804abe73e

  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 8851b793b0ca032efb57bd76ec9198822e1520c2

  repository/src/test/java/org/apache/atlas/TestUtils.java 88edf8f03e356dc4850c16d99f3deb3370d8546d

  repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
4ac001e7fab7bdea744ec275de39ea1fced77903 

Diff: https://reviews.apache.org/r/53653/diff/


Testing
-------

Order by fixes to add ability to orderby on supertypes attributes and with alias. 

Added new aggregate methods support like group by and count, max, min and sum methods.

Executed all existing order by tests successfully. Added new tests to order by with alias


Thanks,

Neeru Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message