atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sarath.ku...@gmail.com>
Subject Re: Review Request 54046: [ATLAS-458] Fix project organization for ATLAS build tools
Date Mon, 28 Nov 2016 18:17:16 GMT


> On Nov. 26, 2016, 1:24 a.m., Madhan Neethiraj wrote:
> > pom.xml, line 1248
> > <https://reviews.apache.org/r/54046/diff/1/?file=1569599#file1569599line1248>
> >
> >     Replace "0.8-incubating-SNAPSHOT" with "${project.version}".

Thanks for the fix Madhan.


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54046/#review156946
-----------------------------------------------------------


On Nov. 23, 2016, 1:44 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54046/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 1:44 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-458
>     https://issues.apache.org/jira/browse/ATLAS-458
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The checkstyle resources are being referenced from the src/build directory which fails
while running "mvn install" within a module directory.
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge-shim/pom.xml 3e0e14a 
>   addons/hive-bridge-shim/pom.xml c699b29 
>   addons/sqoop-bridge-shim/pom.xml efb5a11 
>   addons/storm-bridge-shim/pom.xml 49c56e0 
>   build-tools/pom.xml PRE-CREATION 
>   build-tools/src/main/resources/checkstyle-java-header.txt PRE-CREATION 
>   build-tools/src/main/resources/checkstyle-noframes.xsl PRE-CREATION 
>   build-tools/src/main/resources/checkstyle-suppressions.xml PRE-CREATION 
>   build-tools/src/main/resources/checkstyle.xml PRE-CREATION 
>   build-tools/src/main/resources/enunciate.xml PRE-CREATION 
>   build-tools/src/main/resources/findbugs-exclude.xml PRE-CREATION 
>   common/pom.xml 9f7aac9 
>   graphdb/pom.xml 2fc1f15 
>   intg/pom.xml 1d3578c 
>   notification/pom.xml 868f02d 
>   plugin-classloader/pom.xml c41b309 
>   pom.xml 641165e 
>   shaded/hbase-client-shaded/pom.xml 5251031 
>   shaded/hbase-server-shaded/pom.xml 4a0341e 
>   src/build/checkstyle-java-header.txt 5d5f1e3 
>   src/build/checkstyle-noframes.xsl 4d10dd7 
>   src/build/checkstyle-suppressions.xml bf16a9d 
>   src/build/checkstyle.xml 5442317 
>   src/build/enunciate.xml 777b496 
>   src/build/findbugs-exclude.xml da6c58d 
>   src/main/examples/hive-data-model.json d05ecb3 
> 
> Diff: https://reviews.apache.org/r/54046/diff/
> 
> 
> Testing
> -------
> 
> * Verified by building whole project with m2 cache cleared.
> * 'mvn install' works fine within child modules.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message