atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 53157: [ATLAS-1242] TypesResource API needs to use the new TypesREST API
Date Thu, 17 Nov 2016 20:23:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53157/#review156231
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java (line 97)
<https://reviews.apache.org/r/53157/#comment226389>

    this is already done in line #75 above. Please review and remove.



webapp/src/main/java/org/apache/atlas/util/RestUtils.java (line 267)
<https://reviews.apache.org/r/53157/#comment226393>

    Consider moving this to line #281



webapp/src/main/java/org/apache/atlas/util/RestUtils.java (line 293)
<https://reviews.apache.org/r/53157/#comment226395>

    rename: ifTypeExistsInDefs ==> findClassType



webapp/src/main/java/org/apache/atlas/util/RestUtils.java (line 301)
<https://reviews.apache.org/r/53157/#comment226396>

    consider adding 'break;' after line #301



webapp/src/main/java/org/apache/atlas/util/RestUtils.java (line 313)
<https://reviews.apache.org/r/53157/#comment226398>

    Consider replacing:
      entityDef = registry.getEntityDefByName(attrType)
    
    With:
      AtlasEntityType entityType = (AtlasEntityType) atlasType;
      entityDef = entityType.getEntityDef()



webapp/src/main/java/org/apache/atlas/util/RestUtils.java (line 423)
<https://reviews.apache.org/r/53157/#comment226404>

    ret.valuesMinCount, ret.valuesMaxCount are not copied from attrDefinition. Please refer
to AtlasStructDefStoreV1.toAttributeDefFromJson() for details.



webapp/src/main/java/org/apache/atlas/util/RestUtils.java (line 449)
<https://reviews.apache.org/r/53157/#comment226406>

    lower, upper - fields are not copied from attrDef. Please refer to AtlasStructDefStoreV1.toJsonFromAttributeDef()



webapp/src/main/java/org/apache/atlas/util/RestUtils.java (line 498)
<https://reviews.apache.org/r/53157/#comment226409>

    return type.getTypeCategory() == TypeCategory.ENTITY


- Madhan Neethiraj


On Nov. 16, 2016, 11:59 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53157/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2016, 11:59 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1242
>     https://issues.apache.org/jira/browse/ATLAS-1242
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The current Types API (TypesResource) needs to map to the new v2 Types API (TypesREST).
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6a35d2b 
>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java 64800a5 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d3903fb 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/utils/TypesUtil.java 77cbd39

>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 1eafc7d 
>   webapp/src/test/java/org/apache/atlas/web/resources/TypesJerseyResourceIT.java 7d03689

> 
> Diff: https://reviews.apache.org/r/53157/diff/
> 
> 
> Testing
> -------
> 
> Integration tests for typesResource is successfull - TypesJerseyResourceIT
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message