atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sarath.ku...@gmail.com>
Subject Re: Review Request 53073: Lineage REST API v2 implementation
Date Thu, 10 Nov 2016 23:27:44 GMT


> On Oct. 28, 2016, 12:13 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/discovery/InstanceLineageService.java,
line 183
> > <https://reviews.apache.org/r/53073/diff/2/?file=1543397#file1543397line183>
> >
> >     can you explore how we can merge inputs and outputs at closure query layer?
> 
> Sarath Subramanian wrote:
>     investigated on this, we need to create a new closure query case class to get lineage
on both inputs and outputs (current classes cannot be used). Scala changes needed, will create
a separate jiira to address this.

I have a gremlin query which loops both directions in parallel. The order of path is lost
when the results are combined. Will create a new improvement jiira to make it more efficient.


- Sarath


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review154167
-----------------------------------------------------------


On Nov. 10, 2016, 3:24 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2016, 3:24 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1234
>     https://issues.apache.org/jira/browse/ATLAS-1234
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial model and implementation for updated lineage rest apis for input, output and
full lineage for dataset entity.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba 
>   intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION

>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269 
>   repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION

>   repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53073/diff/
> 
> 
> Testing
> -------
> 
> unit test and integration test updated.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message