atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 53073: Lineage REST API v2 implementation
Date Thu, 10 Nov 2016 20:09:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53073/#review155636
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java (line 32)
<https://reviews.apache.org/r/53073/#comment225648>

    Consider replacing 'String direction' with 'LineageInfoDirection direction'.



intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java (line 39)
<https://reviews.apache.org/r/53073/#comment225646>

    Given that getLineageInfo() covers all directions - input/output/both, are methods getInputLineageInfo(),
getOutputLineageInfo() and getBothLineageInfo() needed anymore?



repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 84)
<https://reviews.apache.org/r/53073/#comment225647>

    is 'direction' argument needed for getInputLineage()? It should implicitly be "input".



repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java (line 276)
<https://reviews.apache.org/r/53073/#comment225649>

    - move member declaration to top of the file
    - consider adding another query with no depth limit. This will be needed to suppor legacy
APIs



webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java (line 67)
<https://reviews.apache.org/r/53073/#comment225652>

    Instead of using "String" type for direction, consider using an enum.



webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java (line 68)
<https://reviews.apache.org/r/53073/#comment225651>

    Why is depth of type 'String'? Consider using Integer type.


- Madhan Neethiraj


On Nov. 8, 2016, 9:46 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53073/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 9:46 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1234
>     https://issues.apache.org/jira/browse/ATLAS-1234
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Initial model and implementation for updated lineage rest apis for input, output and
full lineage for dataset entity.
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fe38fba 
>   intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageService.java PRE-CREATION

>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java aabf269 
>   repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java PRE-CREATION

>   repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53073/diff/
> 
> 
> Testing
> -------
> 
> unit test and integration test updated.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message