atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication
Date Mon, 07 Nov 2016 18:44:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53426/#review155171
-----------------------------------------------------------




webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java (line
112)
<https://reviews.apache.org/r/53426/#comment225009>

    as a good coding practice, enclose 'if' body within "{}"



webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java (line
127)
<https://reviews.apache.org/r/53426/#comment225012>

    as a good coding practice, enclose 'if' body within "{}"



webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java (line
162)
<https://reviews.apache.org/r/53426/#comment225013>

    as a good coding practice, enclose 'if' body within "{}"



webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java (line
171)
<https://reviews.apache.org/r/53426/#comment225014>

    as a good coding practice, enclose 'if' body within "{}"



webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java (line
190)
<https://reviews.apache.org/r/53426/#comment225015>

    Consider replacing with: StringUtils.startsWithIgnoreCase(userAgent, ua)



webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java (line
233)
<https://reviews.apache.org/r/53426/#comment225017>

    Consider moving "cookieName != null" from here to line #231.



webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java (line
234)
<https://reviews.apache.org/r/53426/#comment225016>

    as a good coding practice, enclose 'if' body within "{}"



webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java (line
352)
<https://reviews.apache.org/r/53426/#comment225019>

    getJwtProperties() - the method seems to be initializing this.jwtProperties. Is this intentional?
Perhaps this should go into loadJwtProperties() and have getJwtProperties() simply return
this.jwtProperties.


- Madhan Neethiraj


On Nov. 7, 2016, 12:59 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53426/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 12:59 p.m.)
> 
> 
> Review request for atlas, Ankita Sinha, keval bhatt, Madhan Neethiraj, Shwetha GS, and
Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1244
>     https://issues.apache.org/jira/browse/ATLAS-1244
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch includes new filter for Atlas to Support KnoxSSO Authentication.
> 
> 
> Diffs
> -----
> 
>   distro/src/conf/atlas-application.properties 0349ccc 
>   webapp/pom.xml 6dbd484 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 30200b5

>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/filters/SSOAuthentication.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/filters/SSOAuthenticationProperties.java
PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
595387a 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java
23d3d70 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java
8654716 
>   webapp/src/main/resources/spring-security.xml ea9aa94 
>   webapp/src/main/webapp/WEB-INF/web.xml 7c6bc6d 
>   webapp/src/test/webapp/WEB-INF/web.xml 1b152ee 
> 
> Diff: https://reviews.apache.org/r/53426/diff/
> 
> 
> Testing
> -------
> 
> Verified Knox SSO authentication.
> Verified basic authentication process
> Verified form based authentication process
> 
> All existing test cases passing.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message