atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 53156: ATLAS-1241 Entity v2 APIs and POJOs
Date Tue, 01 Nov 2016 22:36:36 GMT


> On Nov. 1, 2016, 9:38 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityId.java, line 49
> > <https://reviews.apache.org/r/53156/diff/4/?file=1550971#file1550971line49>
> >
> >     Do we need status and version as a part of EntityId?
> >     
> >     Can't we use AtlasObjectId instead of AtlasEntityId?

removed AtlasEntityId. Was not aware of AtlasObjectId. Thanks for catching this.


- Suma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53156/#review154462
-----------------------------------------------------------


On Nov. 1, 2016, 10:17 p.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53156/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 10:17 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1241
>     https://issues.apache.org/jira/browse/ATLAS-1241
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> AtlasEntityHeader - for concise entity representation
> AtlasEntityWithAssociations - for entity represenation with wither associated classifications,
terms etc
> EntityRest - for single entity operations
> EntitiesRest - for multiple entity operations
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java
PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 8bd472a 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java dcccc38 
>   pom.xml 62fc136 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
PRE-CREATION 
>   webapp/pom.xml 82f307c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityRest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53156/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message