Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A421A200BBB for ; Thu, 27 Oct 2016 00:37:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A2B90160AFD; Wed, 26 Oct 2016 22:37:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EB88E160AEE for ; Thu, 27 Oct 2016 00:37:04 +0200 (CEST) Received: (qmail 7050 invoked by uid 500); 26 Oct 2016 22:37:04 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 7035 invoked by uid 99); 26 Oct 2016 22:37:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2016 22:37:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 796F4180666 for ; Wed, 26 Oct 2016 22:37:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.567 X-Spam-Level: X-Spam-Status: No, score=-3.567 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id As0mxTsq1CRU for ; Wed, 26 Oct 2016 22:37:02 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id DE9FE5FC2D for ; Wed, 26 Oct 2016 22:37:00 +0000 (UTC) Received: (qmail 6420 invoked by uid 99); 26 Oct 2016 22:36:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Oct 2016 22:36:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BD62E25BCD9; Wed, 26 Oct 2016 22:36:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3052804415033453359==" MIME-Version: 1.0 Subject: Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef From: Apoorv Naik To: Sarath Subramanian , Madhan Neethiraj , Shwetha GS Cc: Apoorv Naik , atlas Date: Wed, 26 Oct 2016 22:36:05 -0000 Message-ID: <20161026223605.8172.67387@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53207/ X-Sender: Apoorv Naik References: <20161026221000.9386.65353@reviews.apache.org> In-Reply-To: <20161026221000.9386.65353@reviews.apache.org> X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/listener/TypeDefChangeListener.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/listener/ChangeOperation.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas archived-at: Wed, 26 Oct 2016 22:37:05 -0000 --===============3052804415033453359== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ ----------------------------------------------------------- (Updated Oct. 26, 2016, 10:36 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad. Changes ------- Minor enhancements for Indexing support Bugs: ATLAS-1240 https://issues.apache.org/jira/browse/ATLAS-1240 Repository: atlas Description ------- Change listener implementation for legacy TypeSystem TODO: Complete Graph indexer code Diffs (updated) ----- intg/pom.xml 3ac19cf9f5310bd6f04ed5565291de2ec1ec7642 intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ce68e6e4b21ac6e94ae7bfdc6578764c4bdaff6a intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java d26ec0e01871b90c5daad4c3e7b0d7cb597e6263 intg/src/main/java/org/apache/atlas/listener/ChangeOperation.java PRE-CREATION intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java PRE-CREATION intg/src/main/java/org/apache/atlas/listener/TypeDefChangeListener.java PRE-CREATION intg/src/main/java/org/apache/atlas/type/AtlasType.java a507bf4a1a92db6dca4cd569971f91fda9420279 intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8 repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java bbf75aec5b330929cbfd5bc24dfda5a3054aa910 repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 8038815383ebe1a613de7e314bdd5185dab8a629 repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java ebc7ab2ccd85f81993bf771542f97dd67af42c62 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 80feaf6c04a59ee410b18d6e5ac8121e7a419ebb repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5b4eb0e1ba305f3452911d74b8e4c49d5b315e97 repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 96cefe224f651d5e72d05abe210d2160b13e8d69 typesystem/pom.xml c564442d2b34dba818b3a2230b340cf1b8cc34db typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 52637e6f904cbae6122e46a1728237aefb3799d9 webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java a2cfc6221af2c2509b2e57a3bd955a5d54410ff1 webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorModule.java ee6035da62005accea354117423e5f249e39930b Diff: https://reviews.apache.org/r/53207/diff/ Testing ------- 1. UnitTests passing with the new onChange call 2. Tested via curl/postman, changes are reflected immediately Thanks, Apoorv Naik --===============3052804415033453359==--