Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BF908200BA0 for ; Fri, 14 Oct 2016 23:57:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BE0A1160ADD; Fri, 14 Oct 2016 21:57:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0F7AF160AD3 for ; Fri, 14 Oct 2016 23:57:40 +0200 (CEST) Received: (qmail 82189 invoked by uid 500); 14 Oct 2016 21:57:40 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 82178 invoked by uid 99); 14 Oct 2016 21:57:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Oct 2016 21:57:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 54BDBC104D for ; Fri, 14 Oct 2016 21:57:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.817 X-Spam-Level: X-Spam-Status: No, score=-3.817 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id GNSG8nOiuEYP for ; Fri, 14 Oct 2016 21:57:38 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 3DA935FAFA for ; Fri, 14 Oct 2016 21:57:37 +0000 (UTC) Received: (qmail 82150 invoked by uid 99); 14 Oct 2016 21:57:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Oct 2016 21:57:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9BC432D0C57; Fri, 14 Oct 2016 21:57:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8776696965167021108==" MIME-Version: 1.0 Subject: Re: Review Request 52895: ATLAS-1225: Optimize AtlasTypeDefGraphStore to use AtlasTypesRegistry, to reduce queries to Graph DB From: Suma Shivaprasad To: Madhan Neethiraj , Apoorv Naik , atlas Date: Fri, 14 Oct 2016 21:57:35 -0000 Message-ID: <20161014215735.1720.45255@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Suma Shivaprasad X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52895/ X-Sender: Suma Shivaprasad References: <20161014214557.19442.59892@reviews.apache.org> In-Reply-To: <20161014214557.19442.59892@reviews.apache.org> Reply-To: Suma Shivaprasad X-ReviewRequest-Repository: atlas archived-at: Fri, 14 Oct 2016 21:57:41 -0000 --===============8776696965167021108== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 14, 2016, 9:45 p.m., Suma Shivaprasad wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java, line 154 > > > > > > currently I dont see any beaviour diff between the currenty method and above one . Is this still WIP? we can consolidate or reuse if the code paths are same and no diff? - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52895/#review152741 ----------------------------------------------------------- On Oct. 14, 2016, 7:40 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52895/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2016, 7:40 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1225 > https://issues.apache.org/jira/browse/ATLAS-1225 > > > Repository: atlas > > > Description > ------- > > Updated AtlasTypeDefGraphStore to use AtlasTypesRegistry > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java ebfd535 > intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java bc95288 > intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 1473c3a > intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 34f5d49 > intg/src/main/java/org/apache/atlas/type/AtlasMapType.java ca5bb21 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 096f061 > intg/src/main/java/org/apache/atlas/type/AtlasType.java a3f1b02 > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java f4683ff > intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java fcd22f8 > intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 8139fd4 > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 9c0e569 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java 9afccbe > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java c4e7dcd > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java 9726530 > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 728bec3 > > Diff: https://reviews.apache.org/r/52895/diff/ > > > Testing > ------- > > all unit test pass successfully > > > Thanks, > > Madhan Neethiraj > > --===============8776696965167021108==--