Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E4B5B200B9B for ; Wed, 12 Oct 2016 22:16:51 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E33E6160AD4; Wed, 12 Oct 2016 20:16:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 35BCE160ACA for ; Wed, 12 Oct 2016 22:16:51 +0200 (CEST) Received: (qmail 20927 invoked by uid 500); 12 Oct 2016 20:16:50 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 20910 invoked by uid 99); 12 Oct 2016 20:16:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Oct 2016 20:16:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6C0F01806B5 for ; Wed, 12 Oct 2016 20:16:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.567 X-Spam-Level: X-Spam-Status: No, score=-3.567 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dY5iH5CxnuyT for ; Wed, 12 Oct 2016 20:16:47 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 0C0CF5F36A for ; Wed, 12 Oct 2016 20:16:46 +0000 (UTC) Received: (qmail 20476 invoked by uid 99); 12 Oct 2016 20:16:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Oct 2016 20:16:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AE8342D0349; Wed, 12 Oct 2016 20:16:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3778533975061659776==" MIME-Version: 1.0 Subject: Re: Review Request 52585: Implementation of the new TypesREST API From: Apoorv Naik To: Madhan Neethiraj , Sarath Kumar Subramanian , Shwetha GS Cc: Apoorv Naik , atlas Date: Wed, 12 Oct 2016 20:16:32 -0000 Message-ID: <20161012201632.1719.21399@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52585/ X-Sender: Apoorv Naik References: <20161012201619.1719.79555@reviews.apache.org> In-Reply-To: <20161012201619.1719.79555@reviews.apache.org> X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java X-ReviewBoard-Diff-For: intg/src/main/java/org/apache/atlas/api/AtlasApiTypes.java X-ReviewBoard-Diff-For: webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java X-ReviewBoard-Diff-For: repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas archived-at: Wed, 12 Oct 2016 20:16:52 -0000 --===============3778533975061659776== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52585/ ----------------------------------------------------------- (Updated Oct. 12, 2016, 8:16 p.m.) Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and Suma Shivaprasad. Repository: atlas Description ------- TypesREST implementation TODO: 1. Update and delete operations need to be refined 2. Checkstyle/PMD/Findbugs compliance Diffs ----- common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0bdb48235ad3499ab9e7247f503a282798 intg/src/main/java/org/apache/atlas/api/AtlasApiTypes.java 52a35857279b0c5508e226a1159b3d7090e290af intg/src/main/java/org/apache/atlas/model/PList.java a56b7744d8eb7c0137bee881b86c8f8f082acda8 intg/src/main/java/org/apache/atlas/model/SearchFilter.java e35715f24b5ade4822e911da5ffd61c0a4b1af60 intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 31a03f1f7e62cf1e5d7fa1c5510f3a9e83c1eb7d intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 3a8d38b9c7b9bb1cf8a8e75fcb0be0595faa6ea2 intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 087006c4d241171924db59c8ff068fd9538df2c4 intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 017fb0682b670d5a342b70ec997221e7d6138b20 intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java a3fdbcc025bf5f56e7770015d55616ec83d2be64 intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 44d410fad1a7b53f8638767745446ec82cb81318 intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 648d705eb020cba1ee3dd76399c530dfe9182152 intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java b3b2d04bee8229273b2862d95e8c3e77a6894ee3 intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 607d47791a3bfd6052c52de975df7f569f22337b intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java PRE-CREATION intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4b2e32520acc496fb0bf14ca0eeef21c820c0db1 intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java PRE-CREATION repository/pom.xml cdc84294e5278cd68c1890018a4265131fe02322 repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d0792d70d92fb20934e52ff96bd40747c5fcf9cf repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java PRE-CREATION repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java PRE-CREATION repository/src/main/java/org/apache/atlas/util/TypeDefSorter.java PRE-CREATION webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 429df65a86aba1f5a40875e1554d09ec238fb9d2 webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java PRE-CREATION webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e Diff: https://reviews.apache.org/r/52585/diff/ Testing ------- Only via Curl and Postman. Unit/Integration tests are in progress. Thanks, Apoorv Naik --===============3778533975061659776==--