Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7A691200B96 for ; Thu, 6 Oct 2016 08:51:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 77523160AE0; Thu, 6 Oct 2016 06:51:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B5957160AAD for ; Thu, 6 Oct 2016 08:51:18 +0200 (CEST) Received: (qmail 31622 invoked by uid 500); 6 Oct 2016 06:51:17 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 31607 invoked by uid 99); 6 Oct 2016 06:51:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Oct 2016 06:51:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9A9981A0471 for ; Thu, 6 Oct 2016 06:51:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.018 X-Spam-Level: X-Spam-Status: No, score=-5.018 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id TKjoCwzLEPqB for ; Thu, 6 Oct 2016 06:51:15 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 78D645F253 for ; Thu, 6 Oct 2016 06:51:14 +0000 (UTC) Received: (qmail 31580 invoked by uid 99); 6 Oct 2016 06:51:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Oct 2016 06:51:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8F7ED2CACFA; Thu, 6 Oct 2016 06:51:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6045028006523320184==" MIME-Version: 1.0 Subject: Re: Review Request 52533: patch file to add "position" attribute to hive_column type From: Shwetha GS To: Madhan Neethiraj , Shwetha GS Cc: atlas , Sarath Kumar Subramanian Date: Thu, 06 Oct 2016 06:51:12 -0000 Message-ID: <20161006065112.31503.18418@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Shwetha GS X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/52533/ X-Sender: Shwetha GS References: <20161004231700.31503.66261@reviews.apache.org> In-Reply-To: <20161004231700.31503.66261@reviews.apache.org> X-ReviewBoard-Diff-For: src/main/patches/001-hive_column_add_position.json Reply-To: Shwetha GS X-ReviewRequest-Repository: atlas archived-at: Thu, 06 Oct 2016 06:51:19 -0000 --===============6045028006523320184== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52533/#review151632 ----------------------------------------------------------- addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java (line 232) This is a minor backward compatible change. We should set it to 1.1 - Shwetha GS On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52533/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 11:17 p.m.) > > > Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad. > > > Bugs: ATLAS-1210 > https://issues.apache.org/jira/browse/ATLAS-1210 > > > Repository: atlas > > > Description > ------- > > for clients who have not updated to latest code, this patch adds the "position" attribute to hive_column type and updates version to 2.0 > > > Diffs > ----- > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java 28078f4 > distro/src/main/assemblies/standalone-package.xml ff7b784 > repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java c269c3a > src/main/patches/001-hive_column_add_position.json PRE-CREATION > > Diff: https://reviews.apache.org/r/52533/diff/ > > > Testing > ------- > > on older builds - updates the type by adding new attribute and updates version to 2.0 > new builds - ignore the patch since version is already in 2.0 > > > Thanks, > > Sarath Kumar Subramanian > > --===============6045028006523320184==--