atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef
Date Mon, 31 Oct 2016 20:35:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53207/#review154316
-----------------------------------------------------------




repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java (line 1139)
<https://reviews.apache.org/r/53207/#comment223804>

    I understood from the DMS code that we are trying to restore types fro, the store here.
In this we should probably check that the number of types restored is the same as expected?


- Suma Shivaprasad


On Oct. 29, 2016, 12:09 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53207/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2016, 12:09 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma
Shivaprasad.
> 
> 
> Bugs: ATLAS-1240
>     https://issues.apache.org/jira/browse/ATLAS-1240
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Change listener implementation for legacy TypeSystem
> 
> 
> Diffs
> -----
> 
>   intg/pom.xml 3ac19cf9f5310bd6f04ed5565291de2ec1ec7642 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ce68e6e4b21ac6e94ae7bfdc6578764c4bdaff6a

>   intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java d26ec0e01871b90c5daad4c3e7b0d7cb597e6263

>   intg/src/main/java/org/apache/atlas/listener/ChangeOperation.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/listener/TypeDefChangeListener.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/type/AtlasType.java a507bf4a1a92db6dca4cd569971f91fda9420279

>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8

>   intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java b87b33e83c930df8b2e57b00f27f5d3b96e00ac0

>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java bbf75aec5b330929cbfd5bc24dfda5a3054aa910

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
8038815383ebe1a613de7e314bdd5185dab8a629 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
ebc7ab2ccd85f81993bf771542f97dd67af42c62 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
80feaf6c04a59ee410b18d6e5ac8121e7a419ebb 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5b4eb0e1ba305f3452911d74b8e4c49d5b315e97

>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 71a8756e6cf008ca846f41355eb315f2af74a29e

>   repository/src/test/java/org/apache/atlas/TestUtils.java 30071baaededfa954257fe2dcd74e53dac912c42

>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
13b7d22e4ea0f0c75db300e07d6e4613a5e00e8f 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
6de995bc5ccf104b584fd4fce78e26b7a6432d5e 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
7a57518a66e971df7ac722c82558101c6da73815 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerMockTest.java
398ea628f3ba6543163a8fd216a32ed3a2f91424 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java fe15014b3e676012eb9f92bba8b0aa78098e79fa

>   repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java
49ef5516cb6bb75da8ef13d3eda0c175194f4d28 
>   repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 96cefe224f651d5e72d05abe210d2160b13e8d69

>   repository/src/test/scala/org/apache/atlas/query/QueryTestsUtils.scala 33275d3099b0fc4047dd7ca7ddee9bf285199f09

>   typesystem/pom.xml c564442d2b34dba818b3a2230b340cf1b8cc34db 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 52637e6f904cbae6122e46a1728237aefb3799d9

>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java a2cfc6221af2c2509b2e57a3bd955a5d54410ff1

>   webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorModule.java
ee6035da62005accea354117423e5f249e39930b 
> 
> Diff: https://reviews.apache.org/r/53207/diff/
> 
> 
> Testing
> -------
> 
> 1. UnitTests passing with the new onChange call
> 2. Tested via curl/postman, changes are reflected immediately
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message