atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef
Date Thu, 27 Oct 2016 19:35:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53207/
-----------------------------------------------------------

(Updated Oct. 27, 2016, 7:35 p.m.)


Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.


Changes
-------

Removed Indexing support. Currently only LOG messages will show up when onChange is invoked


Bugs: ATLAS-1240
    https://issues.apache.org/jira/browse/ATLAS-1240


Repository: atlas


Description
-------

Change listener implementation for legacy TypeSystem

TODO: Complete Graph indexer code


Diffs (updated)
-----

  intg/pom.xml 3ac19cf9f5310bd6f04ed5565291de2ec1ec7642 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ce68e6e4b21ac6e94ae7bfdc6578764c4bdaff6a

  intg/src/main/java/org/apache/atlas/exception/AtlasBaseException.java d26ec0e01871b90c5daad4c3e7b0d7cb597e6263

  intg/src/main/java/org/apache/atlas/listener/ChangeOperation.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/listener/TypeDefChangeListener.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasType.java a507bf4a1a92db6dca4cd569971f91fda9420279

  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 160f714047bfc626dc29e42694cf86f21ab250a8

  repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java bbf75aec5b330929cbfd5bc24dfda5a3054aa910

  repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
8038815383ebe1a613de7e314bdd5185dab8a629 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
ebc7ab2ccd85f81993bf771542f97dd67af42c62 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
80feaf6c04a59ee410b18d6e5ac8121e7a419ebb 
  repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 5b4eb0e1ba305f3452911d74b8e4c49d5b315e97

  repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 96cefe224f651d5e72d05abe210d2160b13e8d69

  typesystem/pom.xml c564442d2b34dba818b3a2230b340cf1b8cc34db 
  typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 52637e6f904cbae6122e46a1728237aefb3799d9

  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java a2cfc6221af2c2509b2e57a3bd955a5d54410ff1

  webapp/src/main/java/org/apache/atlas/web/service/ActiveInstanceElectorModule.java ee6035da62005accea354117423e5f249e39930b


Diff: https://reviews.apache.org/r/53207/diff/


Testing
-------

1. UnitTests passing with the new onChange call
2. Tested via curl/postman, changes are reflected immediately


Thanks,

Apoorv Naik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message