atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 52257: Return system attributes in get entity definition
Date Mon, 24 Oct 2016 23:51:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review153763
-----------------------------------------------------------




repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java (line
188)
<https://reviews.apache.org/r/52257/#comment223169>

    can you add test for querying by these system attributes as well?


- Suma Shivaprasad


On Oct. 17, 2016, 11:44 a.m., Vimal Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2016, 11:44 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-916
>     https://issues.apache.org/jira/browse/ATLAS-916
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas should maintain system attributes created time, last modified time, created by
user and last modified by user for every entity. This information should be returned in get
entity definition
> 
> 
> Diffs
> -----
> 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 4a68317 
>   repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java fb014f2

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
691a12c 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
8038815 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
ceb6011 
>   repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 92e43cb

>   repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
47ae5e1 
>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
13b7d22 
>   repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
7a57518 
>   typesystem/src/main/java/org/apache/atlas/typesystem/IReferenceableInstance.java 9285014

>   typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/AtlasSystemAttributes.java
PRE-CREATION 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/ReferenceableInstance.java
561cb62 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/ClassType.java 6b530a8 
>   typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
73b3526 
>   typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec

> 
> Diff: https://reviews.apache.org/r/52257/diff/
> 
> 
> Testing
> -------
> 
> Testing done with Hive table creation and updation
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message