atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sarath.ku...@gmail.com>
Subject Re: Review Request 53080: ATLAS-1235: fixed type-update to save updated values for type fields
Date Mon, 24 Oct 2016 23:24:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53080/#review153755
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
(line 417)
<https://reviews.apache.org/r/53080/#comment223165>

    currently we have these type update restrictions:
    1. Only allowed multiplicity update is from required to optional.
    2. New required attributes cannot be added to an existing type (only optional).
    3. The ordinal of old enum value cannot change.
    
    Should we add these type update restrictions?


- Sarath Subramanian


On Oct. 22, 2016, 11:23 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53080/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2016, 11:23 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1235
>     https://issues.apache.org/jira/browse/ATLAS-1235
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Updated the implementation to update the built-in fields - like description. In additon,
added checks to prevent removal of attributes or super-types
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 6299265 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 9ae61a7 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
4bdcf00 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
fd16cbd 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
d5fb584 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
5e42c13 
> 
> Diff: https://reviews.apache.org/r/53080/diff/
> 
> 
> Testing
> -------
> 
> - Verified that built-in fields like description are updated during TypeREST.update()
call
> - Verified that the update() call prevents removal of attributes and supertypes
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message