atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 53080: ATLAS-1235: fixed type-update to save updated values for type fields
Date Fri, 21 Oct 2016 21:46:20 GMT


> On Oct. 21, 2016, 7:41 p.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java,
line 405
> > <https://reviews.apache.org/r/53080/diff/1/?file=1542748#file1542748line405>
> >
> >     we will disallow removal of required attributes for  now and see hot to fix
that later?

The patch prevents delete of any attribte - irrespective of whether optional or mandatory.
We should support attribute delete only after having a mechanism in place to handle existing
entities having value for the attribute.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53080/#review153585
-----------------------------------------------------------


On Oct. 21, 2016, 9:46 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53080/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2016, 9:46 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1235
>     https://issues.apache.org/jira/browse/ATLAS-1235
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Updated the implementation to update the built-in fields - like description. In additon,
added checks to prevent removal of attributes or super-types
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
4bdcf00 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
fd16cbd 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
d5fb584 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
5e42c13 
> 
> Diff: https://reviews.apache.org/r/53080/diff/
> 
> 
> Testing
> -------
> 
> - Verified that built-in fields like description are updated during TypeREST.update()
call
> - Verified that the update() call prevents removal of attributes and supertypes
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message