atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Review Request 53029: ATLAS-1232: added preCreate(), preDelete() in typedef persistence, to enable edge creation for references in a later stage
Date Wed, 19 Oct 2016 19:20:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53029/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1232
    https://issues.apache.org/jira/browse/ATLAS-1232


Repository: atlas


Description
-------

- added preCreate(), which create the type-vertex along with all the attribute. The created
vertex is used by create() method, to add edges to other referenced types
- added preDelete(), which removes all the out-going edges from the type-vertex. The updated
vertex is then removed by delete() method
- after creation of a type, the registry is updated with the generated guid for the type.
GUID is generated by the storage layer, if necessary


Diffs
-----

  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java 058ea44 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 4e741e5 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java f31ee50 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java
2917c20 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
2c81cdf 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java
d997a90 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java
1308bb3 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
12047bf 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
7b6e08a 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
308a529 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
5c55d42 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
eeb08d0 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
6634707 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 0658361 

Diff: https://reviews.apache.org/r/53029/diff/


Testing
-------

- verified that API correctly resolves circular references (from hive_table->hive_column,
hive_column->hive_table) during create and delete operation - done via TypesREST


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message