atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 52585: Implementation of the new TypesREST API
Date Wed, 12 Oct 2016 00:57:15 GMT


> On Oct. 12, 2016, 12:56 a.m., Suma Shivaprasad wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java,
line 68
> > <https://reviews.apache.org/r/52585/diff/17/?file=1531875#file1531875line68>
> >
> >     are all the queries going through indexes or throwing a warning fora full scan?
Can we make sure that indexes are being used.

IMO , adding an index on GUID or typename should suffice in all queries


- Suma


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52585/#review152241
-----------------------------------------------------------


On Oct. 12, 2016, 12:09 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52585/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 12:09 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and
Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> TypesREST implementation
> 
> TODO: Update and delete operations need to be refined
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0bdb48235ad3499ab9e7247f503a282798

>   intg/src/main/java/org/apache/atlas/api/AtlasApiTypes.java 52a35857279b0c5508e226a1159b3d7090e290af

>   intg/src/main/java/org/apache/atlas/model/PList.java a56b7744d8eb7c0137bee881b86c8f8f082acda8

>   intg/src/main/java/org/apache/atlas/model/SearchFilter.java e35715f24b5ade4822e911da5ffd61c0a4b1af60

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java 31a03f1f7e62cf1e5d7fa1c5510f3a9e83c1eb7d

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 3a8d38b9c7b9bb1cf8a8e75fcb0be0595faa6ea2

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 087006c4d241171924db59c8ff068fd9538df2c4

>   intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 017fb0682b670d5a342b70ec997221e7d6138b20

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java a3fdbcc025bf5f56e7770015d55616ec83d2be64

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 44d410fad1a7b53f8638767745446ec82cb81318

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 648d705eb020cba1ee3dd76399c530dfe9182152

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java b3b2d04bee8229273b2862d95e8c3e77a6894ee3

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 607d47791a3bfd6052c52de975df7f569f22337b

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4b2e32520acc496fb0bf14ca0eeef21c820c0db1

>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java PRE-CREATION 
>   repository/pom.xml cdc84294e5278cd68c1890018a4265131fe02322 
>   repository/src/main/java/org/apache/atlas/RepositoryMetadataModule.java d0792d70d92fb20934e52ff96bd40747c5fcf9cf

>   repository/src/main/java/org/apache/atlas/repository/listener/InstanceChangeListener.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/listener/TypeDefChangeListener.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java PRE-CREATION

>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 429df65a86aba1f5a40875e1554d09ec238fb9d2

>   webapp/src/main/java/org/apache/atlas/web/rest/module/RestModule.java PRE-CREATION

>   webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e 
> 
> Diff: https://reviews.apache.org/r/52585/diff/
> 
> 
> Testing
> -------
> 
> Onlt via Curl and Postman.
> 
> Unit/Integration tests are in progress.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message