atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 52585: Implementation of the new TypesREST API
Date Tue, 11 Oct 2016 17:34:35 GMT


> On Oct. 11, 2016, 5:20 p.m., Sarath Kumar Subramanian wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java, line 815
> > <https://reviews.apache.org/r/52585/diff/11/?file=1527929#file1527929line815>
> >
> >     hits null pointer exception when you create a AtlasClassification type. All
entried in createdTypeDefs is null, initialize list

Fixed in the latest patch. Need to update review.


> On Oct. 11, 2016, 5:20 p.m., Sarath Kumar Subramanian wrote:
> > webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java, line 824
> > <https://reviews.apache.org/r/52585/diff/11/?file=1527929#file1527929line824>
> >
> >     another NPE, initialize the list before adding items

Fixed in the latest patch. Need to update review.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52585/#review152161
-----------------------------------------------------------


On Oct. 8, 2016, 5:28 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52585/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2016, 5:28 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and
Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> TypesREST implementation
> 
> TODO: Update and delete operations need to be refined
> 
> 
> Diffs
> -----
> 
>   .gitignore e10adbc4457f6297600f0feb01eb54718b8ec406 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java a3fdbcc025bf5f56e7770015d55616ec83d2be64

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 096f061f16bba3ecb886d00ec66c98ad17c1e243

>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4b2e32520acc496fb0bf14ca0eeef21c820c0db1

>   repository/pom.xml 7a34331ce2876d9d9e916f96f1141d3efa91e959 
>   repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java b342e2700d454b0d6fba595b5cc01cd0e06bbdac

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
263ea465fda0b445a952943def9a6f7c49834f25 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ce87c9d306faa43fb9d3fdc491c4bcbdd7b2bdb

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
5c7cb2e8fa32b540f80beed40fb4f25a89d39c56 
>   repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
2e0414e2cee7ca3d5958650ac6abc8a290473545 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasClassificationDefMapper.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEntityDefMapper.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasEnumDefMapper.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/AtlasStructDefMapper.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/BaseTypeDefMapper.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/factory/AtlasMapperFactory.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasClassificationDefMapperV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEntityDefMapperV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasEnumDefMapperV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/graph/mapper/impl/AtlasStructDefMapperV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/AtlasStore.java PRE-CREATION

>   repository/src/main/java/org/apache/atlas/repository/store/instance/AbstractInstanceStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/instance/AtlasInstanceStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/instance/ClassificationStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/instance/EntityStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/instance/StructStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/typedef/AbstractAtlasStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/typedef/AtlasTypeDefStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/typedef/ClassificationDefStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/typedef/EntityDefStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/typedef/EnumDefStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/typedef/StructDefStore.java
PRE-CREATION 
>   webapp/pom.xml 8fe4b9bed7efefdcc623df2f8e9cfa6ef84d8514 
>   webapp/src/main/java/org/apache/atlas/web/listeners/GuiceServletConfig.java a1d3187cea0422988500195191de37732c7df56f

>   webapp/src/main/java/org/apache/atlas/web/rest/InstancesREST.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/RestModule.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 429df65a86aba1f5a40875e1554d09ec238fb9d2

>   webapp/src/main/resources/errorMessages.properties PRE-CREATION 
>   webapp/src/main/webapp/WEB-INF/web.xml e2a85e9865e52cc86cf385eae1dd6f0e95687a8e 
> 
> Diff: https://reviews.apache.org/r/52585/diff/
> 
> 
> Testing
> -------
> 
> Onlt via Curl and Postman.
> 
> Unit/Integration tests are in progress.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message