atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 52533: patch file to add "position" attribute to hive_column type
Date Thu, 06 Oct 2016 06:51:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52533/#review151632
-----------------------------------------------------------




addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java (line
232)
<https://reviews.apache.org/r/52533/#comment220072>

    This is a minor backward compatible change. We should set it to 1.1


- Shwetha GS


On Oct. 4, 2016, 11:17 p.m., Sarath Kumar Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52533/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 11:17 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1210
>     https://issues.apache.org/jira/browse/ATLAS-1210
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> for clients who have not updated to latest code, this patch adds the "position" attribute
to hive_column type and updates version to 2.0
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java
28078f4 
>   distro/src/main/assemblies/standalone-package.xml ff7b784 
>   repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java c269c3a

>   src/main/patches/001-hive_column_add_position.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52533/diff/
> 
> 
> Testing
> -------
> 
> on older builds - updates the type by adding new attribute and updates version to 2.0
> new builds - ignore the patch since version is already in 2.0
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message