atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suma Shivaprasad <sumasai.shivapra...@gmail.com>
Subject Re: Review Request 52257: Return system attributes in get entity definition
Date Tue, 04 Oct 2016 18:12:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52257/#review151362
-----------------------------------------------------------




typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java (line 54)
<https://reviews.apache.org/r/52257/#comment219696>

    sorry didnt notice  this earlier. Didnt get why these were added as part of the Id?  They
dont uniquely identify an entity and should not go into the Id IMO.


- Suma Shivaprasad


On Oct. 4, 2016, 11:13 a.m., Vimal Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52257/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2016, 11:13 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-916
>     https://issues.apache.org/jira/browse/ATLAS-916
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas should maintain system attributes created time, last modified time, created by
user and last modified by user for every entity. This information should be returned in get
entity definition
> 
> 
> Diffs
> -----
> 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultPropertyMapper.java 2f52b3b 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 66f5bb0 
>   repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 92f98c6

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
263ea46 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ce87c9

>   repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
5c7cb2e 
>   repository/src/main/java/org/apache/atlas/repository/graph/SoftDeleteHandler.java 25aa7c5

>   repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
2e0414e 
>   typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0 
>   typesystem/src/main/scala/org/apache/atlas/typesystem/json/InstanceSerialization.scala
73b3526 
>   typesystem/src/main/scala/org/apache/atlas/typesystem/json/Serialization.scala 68c47ec

>   typesystem/src/test/scala/org/apache/atlas/typesystem/json/InstanceSerializationTest.scala
9e656a5 
> 
> Diff: https://reviews.apache.org/r/52257/diff/
> 
> 
> Testing
> -------
> 
> Testing done with Hive table creation and updation
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message