Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 64BA1200B8C for ; Mon, 12 Sep 2016 11:05:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6355D160AD6; Mon, 12 Sep 2016 09:05:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AA732160AB8 for ; Mon, 12 Sep 2016 11:05:22 +0200 (CEST) Received: (qmail 98196 invoked by uid 500); 12 Sep 2016 09:05:21 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 98183 invoked by uid 99); 12 Sep 2016 09:05:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2016 09:05:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3DD1DC0C99 for ; Mon, 12 Sep 2016 09:05:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.445 X-Spam-Level: X-Spam-Status: No, score=-3.445 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4Hdn2pXMsd_L for ; Mon, 12 Sep 2016 09:05:18 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 5D7295FABF for ; Mon, 12 Sep 2016 09:05:17 +0000 (UTC) Received: (qmail 98140 invoked by uid 99); 12 Sep 2016 09:05:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2016 09:05:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C197A2D2FF5; Mon, 12 Sep 2016 09:05:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2664952235086433947==" MIME-Version: 1.0 Subject: Re: Review Request 51723: ATLAS-1149 : Changes to UI to sort the hive table schema based on "position" attribute of hive_column From: Kalyani Kashikar To: keval bhatt , Madhan Neethiraj , Sarath Kumar Subramanian , Shwetha GS Cc: atlas , Kalyani Kashikar Date: Mon, 12 Sep 2016 09:05:14 -0000 Message-ID: <20160912090514.31231.35711@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kalyani Kashikar X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/51723/ X-Sender: Kalyani Kashikar References: <20160908122229.5210.63471@reviews.apache.org> In-Reply-To: <20160908122229.5210.63471@reviews.apache.org> Reply-To: Kalyani Kashikar X-ReviewRequest-Repository: atlas archived-at: Mon, 12 Sep 2016 09:05:23 -0000 --===============2664952235086433947== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51723/ ----------------------------------------------------------- (Updated Sept. 12, 2016, 9:05 a.m.) Review request for atlas, keval bhatt, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha GS, and Suma Shivaprasad. Bugs: ATLAS-1149 https://issues.apache.org/jira/browse/ATLAS-1149 Repository: atlas Description ------- In hive column needs to be sorted based on its original column order. New attribute "position" has been added to hive_column type which maintains the column order number. UI needs to use this information to sort the column based on this attribute on schema table & entity details page. This patch includes changes for sort column based on "position" attribute Diffs (updated) ----- dashboardv2/public/js/collection/BaseCollection.js b039e30 dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js cc67d01 dashboardv2/public/js/views/schema/SchemaLayoutView.js dc19619 Diff: https://reviews.apache.org/r/51723/diff/ Testing ------- Added hive-brigde jar in atlas-impl dir in hive hook Created new attribute “position” for hive_column type with curl command. Tested entity details page UI for hive_table entities by adding new tables in hive beeline client. In schema table the db column are sorted according to position attribute in api. Thanks, Kalyani Kashikar --===============2664952235086433947==--