atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 51896: ATLAS-1171: structured, high-level APIs
Date Fri, 30 Sep 2016 05:28:10 GMT


> On Sept. 30, 2016, 5:21 a.m., Shwetha GS wrote:
> > Previously, the common module contained some common code required for atlas server.
Since the new classes that are added are client side classes, can you move them to new module
clientv2 so that we have clear dependencies for atlas clients.
> > 
> > Also, move the server side rest API to webappv2 and webapp can depend on webappv2

atlas-common module is being referenced by a number of other modules - not just Atlas server.
Like: typesystem, notification, authorization, hive-bridge, falcon-bridge, sqoop-bridge, storm-bridge.
Hence I have the new classes in atlas-common module.


- Madhan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review150984
-----------------------------------------------------------


On Sept. 30, 2016, 12:04 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 12:04 a.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Selvamohan Neethiraj.
> 
> 
> Bugs: ATLAS-1171
>     https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1171: structured, high-level APIs - phase #1
> - define data-strctures for use in the interface (REST, ..) to describe types and instances:
in package org.apache.atlas.model
> - implementation of runtime behaviour of types - create/validate/normalize instances
(i.e. from values in REST to typed-values): in package org.apache.atlas.type
> 
> I think phase #1 in providing high-level APIs is now ready to review and commit. Please
note this patch only includes new files and there are no changes to any existing code. Please
review.
> 
> Next steps:
> - Phase #2 will include the REST API and the modules that deal with persistence of type
and instance objects (defined in phase #1) in Tital Graph database.
> - Phase #3 will replace current REST API implementation to use the new APIs, while continuing
to provide the current REST API.
> - GUI updates to use the new API can  begin once phase #2 goes in.
> 
> 
> Diffs
> -----
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instance/AtlasClassification.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/type/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasClassificationType.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/type/AtlasEntityType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasStructType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasClassification.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/instance/TestAtlasEntity.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasClassificationDef.java
PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEntityDef.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasEnumDef.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasBigDecimalType.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/type/TestAtlasBigIntegerType.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/type/TestAtlasBooleanType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasByteType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/type/TestAtlasDateType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasDoubleType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasFloatType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasIntType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasLongType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasMapType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/type/TestAtlasShortType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasStringType.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/type/TestAtlasStructType.java PRE-CREATION 
>   pom.xml ac5b042 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51896/diff/
> 
> 
> Testing
> -------
> 
> New unit tests
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message