atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 52336: ReservedTypesRegistrar checks for existence of 1st class type
Date Wed, 28 Sep 2016 07:02:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52336/#review150690
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java (line 150)
<https://reviews.apache.org/r/52336/#comment218729>

    We shouldn't do any updates as part of this, as it might override any type updates from
user. Let the patch framework take care of updates. Lets just create new types as part of
this


- Shwetha GS


On Sept. 28, 2016, 6:27 a.m., Vimal Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52336/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2016, 6:27 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1184
>     https://issues.apache.org/jira/browse/ATLAS-1184
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ReservedTypesRegistrar registers the models for supported integrations like hive, falcon,
sqoop and storm. ReservedTypesRegistrar reads the model files and registers the types defined
in the model file. The check thats done to verify if the model is already registered - checks
for existence of first class type. This will not work if we add more class types to the existing
model or modify the existing type to add optional attributes.
> ReservedTypesRegistrar should check for every type in the model file. Also, ReservedTypesRegistrar
should do type update which does create if not exists, and update if exists
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 41c0155

>   repository/src/test/java/org/apache/atlas/TestUtils.java bd9df62 
>   repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java
d602bd8 
> 
> Diff: https://reviews.apache.org/r/52336/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vimal Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message