atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vimal Sharma <visha...@hortonworks.com>
Subject Review Request 52336: ReservedTypesRegistrar checks for existence of 1st class type
Date Wed, 28 Sep 2016 06:27:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52336/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1184
    https://issues.apache.org/jira/browse/ATLAS-1184


Repository: atlas


Description
-------

ReservedTypesRegistrar registers the models for supported integrations like hive, falcon,
sqoop and storm. ReservedTypesRegistrar reads the model files and registers the types defined
in the model file. The check thats done to verify if the model is already registered - checks
for existence of first class type. This will not work if we add more class types to the existing
model or modify the existing type to add optional attributes.
ReservedTypesRegistrar should check for every type in the model file. Also, ReservedTypesRegistrar
should do type update which does create if not exists, and update if exists


Diffs
-----

  repository/src/main/java/org/apache/atlas/services/ReservedTypesRegistrar.java 41c0155 
  repository/src/test/java/org/apache/atlas/TestUtils.java bd9df62 
  repository/src/test/java/org/apache/atlas/services/ReservedTypesRegistrarTest.java d602bd8


Diff: https://reviews.apache.org/r/52336/diff/


Testing
-------


Thanks,

Vimal Sharma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message