atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shwetha GS <sshivalingamur...@hortonworks.com>
Subject Re: Review Request 52166: Allow optional attributes to be removed when updating type
Date Fri, 23 Sep 2016 06:19:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52166/#review150154
-----------------------------------------------------------



In case the attribute is added again, the data will be wrong. We can't discount that as an
edge case, as it causes data inconsistency. Follow up jiras will hardly be taken up. Its fine
even if we decide that we don't allow adding the attribute again(the deleted attribute). But
we should address the issue completely

Add UTs in all your patches. Just an end to end test for this patch now will not ensure that
this functionality won't be broken in further commits

- Shwetha GS


On Sept. 22, 2016, 6:22 p.m., Sarath Kumar Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52166/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 6:22 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1175
>     https://issues.apache.org/jira/browse/ATLAS-1175
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> we restrict optional attributes to be removed from the type system. This needs to be
allowed
> 
> 
> Diffs
> -----
> 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeUtils.java f5c2ce9 
> 
> Diff: https://reviews.apache.org/r/52166/diff/
> 
> 
> Testing
> -------
> 
> tested using REST calls to delete optional and required attributes and only optional
attributes were removed.
> 
> 
> Thanks,
> 
> Sarath Kumar Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message