atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Hagelberg <jnhagelb...@us.ibm.com>
Subject Re: Review Request 51896: ATLAS-1171: structured, high-level APIs
Date Tue, 20 Sep 2016 19:40:01 GMT


> On Sept. 19, 2016, 11:13 p.m., Jeff Hagelberg wrote:
> > common/src/main/java/org/apache/atlas/model/AtlasAttributeDef.java, line 61
> > <https://reviews.apache.org/r/51896/diff/1/?file=1498599#file1498599line61>
> >
> >     Why is this needed?  It seems like if 'valuesMaxCount' > 1, it is automatically
multi-valued.
> 
> Madhan Neethiraj wrote:
>     Please see my earlier commit. I think the use of explicit attributes like isMultiValued
make it easier to read/understand.

I think that makes sense, but what happens if someone sets isMultiValued=true and valuesMaxCount=0.
 Would a configuration like that be allowed?  It seems like the parameters should be defined
in a way that does not allow invalid configurations to be specified.


- Jeff


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review149121
-----------------------------------------------------------


On Sept. 20, 2016, 8:06 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 8:06 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1171
>     https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> first-cut API for review
> 
> 
> Diffs
> -----
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/PList.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/instances/AtlasEntity.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/instances/AtlasObjectId.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/instances/AtlasProcess.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/instances/AtlasStruct.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/instances/AtlasTrait.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/types/AtlasBaseTypeDef.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/types/AtlasEntityDef.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/types/AtlasEnumDef.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/types/AtlasStructDef.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/types/AtlasTraitDef.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/typesystem/AtlasArrayType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/typesystem/AtlasBuiltInTypes.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/typesystem/AtlasDataType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/typesystem/AtlasEntityType.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/typesystem/AtlasEnumType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/typesystem/AtlasMapType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/typesystem/AtlasStructType.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/typesystem/AtlasTraitType.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/typesystem/AtlasTypeRegistry.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/ModelTestUtil.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/instances/TestAtlasEntity.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/types/TestAtlasEntityDef.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/types/TestAtlasEnumDef.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/types/TestAtlasStructDef.java PRE-CREATION

>   common/src/test/java/org/apache/atlas/model/types/TestAtlasTraitDef.java PRE-CREATION

>   pom.xml ac5b042 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51896/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message