atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david_rad...@uk.ibm.com>
Subject Re: Review Request 51896: ATLAS-1171: structured, high-level APIs
Date Thu, 15 Sep 2016 15:25:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51896/#review149064
-----------------------------------------------------------



Some thoughts on this change.

I notice AltasEntities is a new interface that you have introduced. I cannot see it being
used anywhere. The methods in this and other interfaces all throw Exception, if this is an
API interface then I think it needs specific Exceptions.
I think that an API change to help understanding needs to have comprehensive javadoc to explain
the inputs and outputs - this is what I expected from the Jira description.
It looks like there is a only one test introduced. I think for an API change like this you
should aim to add in comprehensive testing; normal paths, maximum and minimums of parameters
(values and lengths), non-standard characters in any supplied strings and tests of the expected
errors for error cases.

- David Radley


On Sept. 14, 2016, 5:33 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51896/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 5:33 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1171
>     https://issues.apache.org/jira/browse/ATLAS-1171
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> first-cut API for review
> 
> 
> Diffs
> -----
> 
>   common/pom.xml e3b6465 
>   common/src/main/java/org/apache/atlas/api/AtlasEntities.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/AtlasTypes.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/api/SearchFilter.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasAttributeDef.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/AtlasBuiltInDatatypes.java PRE-CREATION

>   common/src/main/java/org/apache/atlas/model/AtlasEntity.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasEntityDef.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasEnumDef.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasObjectId.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasProcess.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasStruct.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasStructDef.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasTrait.java PRE-CREATION 
>   common/src/main/java/org/apache/atlas/model/AtlasTraitDef.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/model/TestAtlasEntity.java PRE-CREATION 
>   pom.xml 95f28b0 
> 
> Diff: https://reviews.apache.org/r/51896/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message