atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 51660: [ATLAS-1098] Added keyword checks while creating a new tag/trait
Date Tue, 13 Sep 2016 04:52:44 GMT


> On Sept. 13, 2016, 4:40 a.m., Shwetha GS wrote:
> > repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java,
line 309
> > <https://reviews.apache.org/r/51660/diff/3/?file=1492519#file1492519line309>
> >
> >     This is equals check - typename equals keyword. Does it work if typename contains
keyword e.g., if typename is 'isa PII'?
> >     
> >     Not sure if keywords in DSL is case sensitive. You may want to verify

Right now this will go through.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51660/#review148651
-----------------------------------------------------------


On Sept. 6, 2016, 11:27 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51660/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2016, 11:27 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Shwetha GS, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> [ATLAS-1098] Added keyword checks while creating a new tag/trait
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 4d05d49

> 
> Diff: https://reviews.apache.org/r/51660/diff/
> 
> 
> Testing
> -------
> 
> Tested with all possible keywords specified in the QueryParser, the UI shows a red exception
message stating that the type being created is a keyword
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message