atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keval bhatt <kbh...@apache.org>
Subject Re: Review Request 51723: ATLAS-1149 : Changes to UI to sort the hive table schema based on "position" attribute of hive_column
Date Fri, 09 Sep 2016 12:00:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51723/#review148328
-----------------------------------------------------------




dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js (line 61)
<https://reviews.apache.org/r/51723/#comment215802>

    http://underscorejs.org/#sortBy does not do inplace sorting, so `valueObject.columns`
first needs to be replaced with `valueSorted` before passing it to `CommonViewFunction.propertyTable`
    
    Can you please check and verify it?


- keval bhatt


On Sept. 8, 2016, 12:22 p.m., Kalyani Kashikar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51723/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 12:22 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Sarath Kumar Subramanian, Shwetha
GS, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1149
>     https://issues.apache.org/jira/browse/ATLAS-1149
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> In hive column needs to be sorted based on its original column order. New attribute "position"
has been added to hive_column type which maintains the column order number. UI needs to use
this information to sort the column based on this attribute on schema table & entity details
page.
> 
> This patch includes changes for sort column based on "position" attribute
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/collection/BaseCollection.js b039e30 
>   dashboardv2/public/js/views/entity/EntityDetailTableLayoutView.js cc67d01 
>   dashboardv2/public/js/views/schema/SchemaLayoutView.js dc19619 
> 
> Diff: https://reviews.apache.org/r/51723/diff/
> 
> 
> Testing
> -------
> 
> Added hive-brigde jar in atlas-impl dir in hive hook
> Created new attribute “position” for hive_column type with curl command.
> Tested entity details page UI for hive_table entities by adding new tables in hive beeline
client.
> In schema table the db column are sorted according to position attribute in api.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message