Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============1042905103721383132=="
MIME-Version: 1.0
Subject: Re: Review Request 51514: [ATLAS-1144] Create/update entity API call
 should return more definitions
From: Madhan Neethiraj <madhan@apache.org>
To: Madhan Neethiraj <madhan@apache.org>
Cc: Apoorv Naik <naik.apoorv@gmail.com>, atlas <dev@atlas.incubator.apache.org>
Date: Wed, 31 Aug 2016 05:22:46 -0000
Message-ID: <20160831052246.1642.30818@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Madhan Neethiraj <noreply@reviews.apache.org>
References: <20160830154437.1642.81443@reviews.apache.org>
In-Reply-To: <20160830154437.1642.81443@reviews.apache.org>
Reply-To: Madhan Neethiraj <madhan@apache.org>
archived-at: Wed, 31 Aug 2016 05:22:52 -0000

--===============1042905103721383132==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51514/#review147407
-----------------------------------------------------------


webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java (line 197)
<https://reviews.apache.org/r/51514/#comment214560>

    Does every request have its own 'uriInfo' object? If not, how does this method differentiate requests that include "responseType" query parameter from the ones that don't?


- Madhan Neethiraj


On Aug. 30, 2016, 3:44 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51514/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2016, 3:44 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The bug states that the API response only shows one entity definition in the response of an update/create call wherease the expectation seems to be of getting the entire list of the entities that were created/updated.
> 
> The fix adds the required capability by the means of a query parameter responseType with the value as "full", if the API call is made with this extra parameter, the response would contain an additional field called "definitionList" which is of type JsonArray. If the parameter is unspecified, the API response remains unaffected.
> 
> 
> Diffs
> -----
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 82016d0 
> 
> Diff: https://reviews.apache.org/r/51514/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


--===============1042905103721383132==--